Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#27722 closed enhancement (fixed)

Remove old deprecation warning of Minkowski -> minkowski

Reported by: jipilab Owned by:
Priority: major Milestone: sage-8.8
Component: geometry Keywords: deprecation, polytope
Cc: vdelecroix, tscrim Merged in:
Authors: Jean-Philippe Labbé Reviewers: Frédéric Chapoton, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 5b9c9ae (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

#23685 renamed the minkowski methods. It should now be removed.

Change History (7)

comment:1 Changed 3 years ago by jipilab

  • Branch set to u/jipilab/27722
  • Commit set to 2ea49f153168219131d82263fca3335fc1305186
  • Status changed from new to needs_review

New commits:

​589b556Removed old deprecation warnings
​2ea49f1removed a forgotten line

comment:2 Changed 3 years ago by tscrim

I think you should squash the two commits together (and you can just force push it) to keep a more clean git history.

Last edited 3 years ago by tscrim (previous) (diff)

comment:3 Changed 3 years ago by git

  • Commit changed from 2ea49f153168219131d82263fca3335fc1305186 to 5b9c9aecc797e1d45d3b84039ca9f5ef62c45c3b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​5b9c9aeRemoved old deprecation warnings

comment:4 Changed 3 years ago by jipilab

Done!

comment:5 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton, Travis Scrimshaw
  • Status changed from needs_review to positive_review

ok, thx

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/jipilab/27722 to 5b9c9aecc797e1d45d3b84039ca9f5ef62c45c3b
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 2 years ago by mkoeppe

  • Commit 5b9c9aecc797e1d45d3b84039ca9f5ef62c45c3b deleted
  • Reviewers changed from Frédéric Chapoton, Travis Scrimshaw to Frédéric Chapoton, Travis Scrimshaw
Note: See TracTickets for help on using tickets.