Opened 2 years ago

Closed 2 years ago

Last modified 23 months ago

#27713 closed defect (fixed)

Patch pynac to build properly with Cygwin's system GMP

Reported by: embray Owned by:
Priority: critical Milestone: sage-8.8
Component: porting: Cygwin Keywords: gmp pynac
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 5816c4b (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

There are some bits in plain GMP not present for some reason in MPIR such that Cygwin gets some configure-time flags set differently than the defaults on Linux. Cygwin's system package for GMP is configured with these different defaults, leading to a build failure in pynac that I don't get on other platforms.

See the upstream PR for more details: https://github.com/pynac/pynac/pull/342

Change History (7)

comment:1 Changed 2 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/cygwin/build/ticket-27713
  • Status changed from new to needs_review

comment:2 Changed 2 years ago by git

  • Commit set to 5816c4b75a1a1ed823b7eb20ba5b3de48237032c

Branch pushed to git repo; I updated commit sha1. New commits:

5816c4bTrac #27713: Include patch to pynac to fix build issue when using Cygwin's system GMP

comment:3 Changed 2 years ago by embray

To add, this started of course since #27212. Not sure why I didn't catch the problem before since I have recollection of testing this on Cygwin, but maybe I just never rebuilt everything (including pynac?) from scratch for some reason.

comment:4 Changed 2 years ago by embray

  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

Fixed upstream. rws confirms there will be a new pynac release in a few weeks, so we can possibly wait on that as well.

comment:5 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I think we can add this patch now (in part to get some extra testing through Sage beta releases) and then remove it when we upgrade Pynac (if that does get into the next stable Sage release).

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/embray/cygwin/build/ticket-27713 to 5816c4b75a1a1ed823b7eb20ba5b3de48237032c
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 23 months ago by dimpase

  • Commit 5816c4b75a1a1ed823b7eb20ba5b3de48237032c deleted

the update with the patch in has been released, see #28016

Note: See TracTickets for help on using tickets.