#27711 closed enhancement (fixed)

Remove deprecated parameter "implementation" from Graph and DiGraph constructors

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.8
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 95269b9 (Commits) Commit: 95269b91b6eb6eca53a9ab422f3a0fbd11d0e0ee
Dependencies: Stopgaps:

Description (last modified by dcoudert)

Parameter "implementation" from Graph and DiGraph? constructors is deprecated since the removal of the networkx backend in #18375.

This is a big ticket that touches many files.

Change History (9)

comment:1 Changed 10 months ago by dcoudert

  • Branch set to public/graphs/27711_remove_parameter_implementation
  • Commit set to 52312802135e0744088ce0a4fd634f06ac2c314e
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

5231280trac #27711: remove deprecated parameter implementation from constructors

comment:2 Changed 10 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thx

comment:3 Changed 10 months ago by vbraun

Merge conflict

comment:4 Changed 10 months ago by vbraun

  • Status changed from positive_review to needs_work

comment:5 Changed 10 months ago by git

  • Commit changed from 52312802135e0744088ce0a4fd634f06ac2c314e to 95269b91b6eb6eca53a9ab422f3a0fbd11d0e0ee

Branch pushed to git repo; I updated commit sha1. New commits:

95269b9trac #27711: fix merge conflict with 8.8.beta4

comment:6 Changed 10 months ago by dcoudert

  • Status changed from needs_work to needs_review

Merge conflict fixed. Ready for review.

comment:7 Changed 10 months ago by chapoton

  • Status changed from needs_review to positive_review

ok again

comment:8 Changed 10 months ago by dcoudert

Thank you.

comment:9 Changed 10 months ago by vbraun

  • Branch changed from public/graphs/27711_remove_parameter_implementation to 95269b91b6eb6eca53a9ab422f3a0fbd11d0e0ee
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.