Opened 2 years ago

Closed 2 years ago

#27702 closed defect (fixed)

psutil cygwin patch broken on Cygwin 3

Reported by: embray Owned by:
Priority: critical Milestone: sage-8.8
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 97f0883 (Commits, GitHub, GitLab) Commit: 97f0883e6001aa8d9a139944359707c391ad4ea7
Dependencies: Stopgaps:

Status badges

Description

The patch contains some module-level parsing of the Cygwin version number, but this is not actually used by the patch or anywhere in Sage that I can tell.

Unfortunately this broke in Cygwin 3.0 which changed the version number format.

I have been working on a complete revamp of the Cygwin port of psutil that will hopefully be accepted upstream. It isn't finished yet so in the meantime it is easiest to just update the old patch to remove the unused version parsing stuff.

Change History (3)

comment:1 Changed 2 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/pkgs/psutil/cygwin-update
  • Commit set to 97f0883e6001aa8d9a139944359707c391ad4ea7
  • Status changed from new to needs_review

As I predicted, this was straightforward, and removing the broken (but unused) version parsing didn't affect anything else.

Hope to have the new psutil port in a few weeks' time.


New commits:

97f0883Trac #27702: Remove version parsing from Cygwin patch to psutil.

comment:2 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/embray/pkgs/psutil/cygwin-update to 97f0883e6001aa8d9a139944359707c391ad4ea7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.