Opened 3 years ago
Closed 3 years ago
#27691 closed enhancement (fixed)
py3: care for two files in misc
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  python3  Keywords:  
Cc:  tscrim, vklein  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  281bc44 (Commits, GitHub, GitLab)  Commit:  281bc4400e74af7cf782d94dcb2165764801d2d6 
Dependencies:  Stopgaps: 
Description
both having one failing doctest
Change History (7)
comment:1 Changed 3 years ago by
 Branch set to u/chapoton/27691
 Commit set to 93a1f5ad85607260f2ae1288dab6cc31ba0e5fbf
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Commit changed from 93a1f5ad85607260f2ae1288dab6cc31ba0e5fbf to 281bc4400e74af7cf782d94dcb2165764801d2d6
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
281bc44  py3: some care for two files in misc

comment:4 Changed 3 years ago by
I am slightly worried about why this change is necessary:
 sage: timeit('sleep(0.5)', number=3) # long time (5s on sage.math, 2012) + sage: timeit('sleep(float(0.5))', number=3) # long time (5s on sage.math, 2012)
I should note the preparser does not convert 0.5
to an element of RR
:
sage: preparse("timeit('sleep(0.5)', number=3)") "timeit('sleep(0.5)', number=Integer(3))"
If it is just something that is needed, then I will just set this to a positive review, but I would like to know why it is needed.
comment:5 Changed 3 years ago by
see #26314
comment:6 Changed 3 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Okay, let it be so.
comment:7 Changed 3 years ago by
 Branch changed from u/chapoton/27691 to 281bc4400e74af7cf782d94dcb2165764801d2d6
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3: some care for two files in misc