Opened 4 years ago

Closed 4 years ago

#27685 closed defect (fixed)

test for containment in ideals of infinite orders

Reported by: gh-BrentBaccala Owned by:
Priority: minor Milestone: sage-8.8
Component: algebra Keywords: function fields
Cc: Merged in:
Authors: Brent Baccala Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c381796 (Commits, GitHub, GitLab) Commit: c3817961a1e444c5666ba7d8eb9e99174d46b769
Dependencies: Stopgaps:

Status badges

Description

In the current function field code, ideals of infinite orders do not support containment testing: 

sage: K.<x> = FunctionField(GF(3^2)); R.<t> = K[]
sage: F.<y> = K.extension(t^3 + t^2 - x^4)
sage: Oinf = F.maximal_order_infinite()
sage: I = Oinf.ideal(1/y)
sage: 1/y in I
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-19-a3f98a86502f> in <module>()
----> 1 Integer(1)/y in I

TypeError: argument of type 'IdealMonoid_with_category.element_class' is not iterable

Ideals of finite orders do support such tests: 

sage: O = F.maximal_order()
sage: I = O.ideal(y)
sage: y in I
True

Change History (7)

comment:1 Changed 4 years ago by gh-BrentBaccala

Authors: → Brent Baccala
Branch: → public/27685
Commit: → 14762e78ce8cb20a3ab0f55b054ea6077c876bc9
Status: new → needs_review

New commits:

​14762e7Trac #27685: add __contains__ methods to ideals of infinite orders

comment:2 Changed 4 years ago by git

Commit: 14762e78ce8cb20a3ab0f55b054ea6077c876bc9 → d1bfb3a8b8c29a085d3549341346ec296fe9588d

Branch pushed to git repo; I updated commit sha1. New commits:

​d1bfb3aMerge tag '8.8.beta5' into public/27685

comment:3 Changed 4 years ago by tscrim

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review

LGTM.

comment:4 Changed 4 years ago by vbraun

Status: positive_review → needs_work

Merge conflict, please fix

comment:5 Changed 4 years ago by git

Commit: d1bfb3a8b8c29a085d3549341346ec296fe9588d → c3817961a1e444c5666ba7d8eb9e99174d46b769

Branch pushed to git repo; I updated commit sha1. New commits:

​c381796Merge branch 'public/27685' of git://trac.sagemath.org/sage into public/27685

comment:6 Changed 4 years ago by tscrim

Status: needs_work → positive_review

Fixed.

comment:7 Changed 4 years ago by vbraun

Branch: public/27685 → c3817961a1e444c5666ba7d8eb9e99174d46b769
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.