## #27684 closed enhancement (fixed)

# Upgrade dot2tex to 2.11.3

Reported by: | Travis Scrimshaw | Owned by: | |
---|---|---|---|

Priority: | major | Milestone: | sage-8.8 |

Component: | packages: optional | Keywords: | upgrade, dot2tex |

Cc: | Jeroen Demeyer, Erik Bray, Frédéric Chapoton, Nicolas M. Thiéry, Anne Schilling, bsalisbury01 | Merged in: | |

Authors: | Travis Scrimshaw | Reviewers: | Anne Schilling, Nicolas M. Thiéry |

Report Upstream: | N/A | Work issues: | |

Branch: | 7add7a6 (Commits, GitHub, GitLab) | Commit: | |

Dependencies: | Stopgaps: |

### Description

A straightforward upgrade, which includes support for Python3. I also fix something in `spkg-check`

to use the Python installed by Sage.

### Change History (11)

### comment:1 Changed 4 years ago by

Branch: | → public/packages/upgrade_dot2tex_2_11_3-27684 |
---|---|

Commit: | → 7add7a663481f22cea133b3b6905ce0cd94b2481 |

Status: | new → needs_review |

### comment:2 Changed 4 years ago by

I haven't tested it yet, but otherwise this looks fine to me! Thanks Travis. I got hit by that lack of support for Python3 two days ago!

### comment:3 Changed 4 years ago by

I tested this both on Python2 and 3 (in part because I wrote the dot2tex port PR). I completely forgot to do this upgrade ticket until today when I was upgrading my python3 build. `:P`

Sorry it was a little late for you.

### comment:4 Changed 4 years ago by

Could you give some instructions on how to test your changes? Get your branch and then install the tarball?

### comment:5 follow-up: 6 Changed 4 years ago by

You will need to get the branch and download the tarball from the link in the description, putting it in the `$SAGE_ROOT/upstream`

folder. Then just run `make build`

or `sage -i dot2tex`

. You can also run `sage -i -c dot2tex`

if you want to run the spkg's test suite.

### comment:6 Changed 4 years ago by

Replying to tscrim:

You will need to get the branch and download the tarball from the link in the description, putting it in the

`$SAGE_ROOT/upstream`

folder. Then just run`make build`

or`sage -i dot2tex`

. You can also run`sage -i -c dot2tex`

if you want to run the spkg's test suite.

Ok, thanks! Now that I could finally build sage again, I tried out your updated dot2tex package and it seems to work great.

### comment:7 Changed 4 years ago by

Reviewers: | → Anne Schilling, Nicolas Thiery |
---|---|

Status: | needs_review → positive_review |

### comment:9 Changed 4 years ago by

Branch: | public/packages/upgrade_dot2tex_2_11_3-27684 → 7add7a663481f22cea133b3b6905ce0cd94b2481 |
---|---|

Resolution: | → fixed |

Status: | positive_review → closed |

### comment:10 Changed 3 years ago by

Commit: | 7add7a663481f22cea133b3b6905ce0cd94b2481 |
---|

Followup : #28332

Please also run self-tests when upgrading a package.

### comment:11 Changed 3 years ago by

Reviewers: | Anne Schilling, Nicolas Thiery → Anne Schilling, Nicolas M. Thiéry |
---|

**Note:**See TracTickets for help on using tickets.

New commits:

`Upgrade dot2tex to 2.11.3 and additional changes for Python3.`