Opened 12 months ago
Closed 12 months ago
#27682 closed enhancement (fixed)
upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package eantic
Reported by:  vdelecroix  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  packages: optional  Keywords:  
Cc:  Winfried, jipilab, ghsebasguts, mkoeppe  Merged in:  
Authors:  Vincent Delecroix, Matthias Koeppe  Reviewers:  JeanPhilippe Labbé, Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  64f1f19 (Commits)  Commit:  64f1f19d7c6003a4d85abd8626dfab2e45979107 
Dependencies:  Stopgaps: 
Description (last modified by )
New release of Normaliz is available.
It depends on an additional library eantic that is packaged in this ticket.
Tarballs
 https://github.com/Normaliz/Normaliz/releases/download/v3.7.1/normaliz3.7.1.tar.gz
 http://www.labri.fr/perso/vdelecro/eantic/eantic0.1.3b0.tar.gz
 https://files.pythonhosted.org/packages/69/74/a32187f49a2524978d9bc6f704049d8021b555abe3b71aa74b687a958217/PyNormaliz2.1.tar.gz
follow up tickets: #25091, #25097
(see also the metaticket #22420)
Step by step instructions if you want to try it out
 Go to the Sage source tree and pull the branch associated to this ticket
 Get the eantic and normaliz tarballs and put them in the
upstream
repository$ wget P upstream https://github.com/Normaliz/Normaliz/releases/download/v3.7.1/normaliz3.7.1.tar.gz $ wget P upstream http://www.labri.fr/perso/vdelecro/eantic/eantic0.1.3b0.tar.gz $ wget P upstream https://files.pythonhosted.org/packages/69/74/a32187f49a2524978d9bc6f704049d8021b555abe3b71aa74b687a958217/PyNormaliz2.1.tar.gz
 Compile and install everything
$ sage i pynormaliz
 Run make
$ make build
Change History (29)
comment:1 Changed 12 months ago by
 Branch set to u/vdelecroix/27682
 Commit set to 6e96a5a6f8c3fcfea45428a980832579a1294dc9
comment:2 Changed 12 months ago by
 Description modified (diff)
comment:3 Changed 12 months ago by
 Commit changed from 6e96a5a6f8c3fcfea45428a980832579a1294dc9 to 7618ea92cd050420da53a507c17274b5527d5820
comment:4 Changed 12 months ago by
 Commit changed from 7618ea92cd050420da53a507c17274b5527d5820 to d752708b7289be4b18599312a7396e614c349cbe
Branch pushed to git repo; I updated commit sha1. New commits:
d752708  upgrade normaliz

comment:5 Changed 12 months ago by
 Description modified (diff)
 Summary changed from upgrade normaliz to 3.7.0 to upgrade normaliz to 3.7.0, pynormaliz to ? and package eantic
comment:6 Changed 12 months ago by
 Cc mkoeppe added
 Description modified (diff)
comment:7 Changed 12 months ago by
So far, both packages install without issues on debian stretch with gcc 6.3.0. Waiting for the tarball for the new version of pynormaliz.
comment:8 Changed 12 months ago by
 Description modified (diff)
comment:9 Changed 12 months ago by
 Description modified (diff)
comment:10 Changed 12 months ago by
 Commit changed from d752708b7289be4b18599312a7396e614c349cbe to 4eb02f8a0077cbc1e562e6d46ef6fadefa3ffc46
Branch pushed to git repo; I updated commit sha1. New commits:
4eb02f8  fix doctest in backend_normaliz.py

comment:11 Changed 12 months ago by
 Description modified (diff)
comment:12 followup: ↓ 13 Changed 12 months ago by
After a make distclean
and proper reinstall as the ticket description, I got everything back in order and all tests pass in the folder polyhedron
.
comment:13 in reply to: ↑ 12 ; followup: ↓ 14 Changed 12 months ago by
comment:14 in reply to: ↑ 13 Changed 12 months ago by
Replying to vdelecroix:
Replying to jipilab:
After a
make distclean
and proper reinstall as the ticket description, I got everything back in order and all tests pass in the folderpolyhedron
.Then could you try to reproduce #22, #23, #26, #27? (and report back on the github issues)
Just to confirm: all 4 issues are now solved in sage (some of them had different traces inside of sage...).
and
$ sage t *.py optional=dochtml,e_antic,gfortran,memlimit,mpir,normaliz,python2,sage,pynormaliz Using optional=dochtml,e_antic,gfortran,memlimit,mpir,normaliz,pynormaliz,python2,sage Doctesting 25 files.  All tests passed! 
comment:15 Changed 12 months ago by
 Commit changed from 4eb02f8a0077cbc1e562e6d46ef6fadefa3ffc46 to e5c669d540ee5c34605618ea0658b94a3c29c43b
comment:16 Changed 12 months ago by
 Description modified (diff)
comment:17 Changed 12 months ago by
 Description modified (diff)
comment:18 Changed 12 months ago by
Please no force pushs... I'm merging this ticket in #25097...
comment:19 Changed 12 months ago by
sorry... won't do anymore.
comment:20 Changed 12 months ago by
On the other hand, it does not make much sense to merge anywhere. Normaliz and eantic needs upgrade and PyNormaliz needs to be fixed and released.
comment:21 Changed 12 months ago by
Yes, of course I'm waiting for these upgrades.
comment:22 Changed 12 months ago by
 Description modified (diff)
comment:23 Changed 12 months ago by
 Description modified (diff)
comment:24 Changed 12 months ago by
 Description modified (diff)
 Summary changed from upgrade normaliz to 3.7.0, pynormaliz to ? and package eantic to upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package eantic
comment:25 Changed 12 months ago by
 Branch changed from u/vdelecroix/27682 to u/mkoeppe/27682
comment:26 Changed 12 months ago by
 Commit changed from e5c669d540ee5c34605618ea0658b94a3c29c43b to 64f1f19d7c6003a4d85abd8626dfab2e45979107
 Status changed from new to needs_review
comment:27 Changed 12 months ago by
Builds and tests (polyhedron
and thematic_tutorial
folders) Oll Korrekt on debian stretch.
comment:28 Changed 12 months ago by
 Reviewers set to JeanPhilippe Labbé, Travis Scrimshaw
 Status changed from needs_review to positive_review
It passes all tests for me (in particular, in the folder I care about: combinat/rigged_configurations
;)
). I am also getting around a 510% speedup in my tests:
sage: RC = RiggedConfigurations(['E',8,1], [[4,1]]) sage: %time len(RC.kleber_tree()) CPU times: user 2.29 s, sys: 8.24 ms, total: 2.3 s Wall time: 352 ms 87 sage: RC = RiggedConfigurations(['E',8,1], [[4,1],[2,1]]) sage: %time len(RC.kleber_tree()) CPU times: user 53.4 s, sys: 52.1 ms, total: 53.5 s Wall time: 7.68 s 2137 sage: RC = RiggedConfigurations(['F',4,1], [[3,2],[2,2]]) sage: %time len(RC.kleber_tree()) CPU times: user 9.18 s, sys: 20.3 ms, total: 9.2 s Wall time: 1.85 s 1257
vs before
sage: RC = RiggedConfigurations(['E',8,1], [[4,1]]) sage: %time len(RC.kleber_tree()) CPU times: user 2.29 s, sys: 7.74 ms, total: 2.29 s Wall time: 360 ms 87 sage: RC = RiggedConfigurations(['E',8,1], [[4,1],[2,1]]) sage: %time len(RC.kleber_tree()) CPU times: user 55.7 s, sys: 59.4 ms, total: 55.8 s Wall time: 8.23 s 2137 sage: RC = RiggedConfigurations(['F',4,1], [[3,2],[2,2]]) sage: %time len(RC.kleber_tree()) CPU times: user 9.43 s, sys: 24 ms, total: 9.45 s Wall time: 1.92 s 1257
comment:29 Changed 12 months ago by
 Branch changed from u/mkoeppe/27682 to 64f1f19d7c6003a4d85abd8626dfab2e45979107
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
package eantic