Opened 2 years ago

Closed 2 years ago

#27667 closed enhancement (fixed)

py3: partial cure for finite state machines

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: cheuberg, dkrenn Merged in:
Authors: Frédéric Chapoton Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: a21c793 (Commits, GitHub, GitLab) Commit: a21c79309c67c4fe9ab130c35a70825fb4aa8136
Dependencies: Stopgaps:

Status badges

Description

by changing the repr, so that frozensets are handled the same in py2 and py3

Change History (9)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27667
  • Commit set to f5f8938af7de1749b86fa9910b1c5cfa0111bf63
  • Status changed from new to needs_review

New commits:

​f5f8938pretty for fsm

comment:2 Changed 2 years ago by dkrenn

  • Cc cheuberg dkrenn added

comment:3 Changed 2 years ago by chapoton

green bot, please review

comment:4 Changed 2 years ago by dkrenn

  • Branch changed from u/chapoton/27667 to u/dkrenn/27667

comment:5 follow-up: Changed 2 years ago by dkrenn

  • Commit changed from f5f8938af7de1749b86fa9910b1c5cfa0111bf63 to a21c79309c67c4fe9ab130c35a70825fb4aa8136
  • Reviewers set to Daniel Krenn

I am fine with the changes.

New commits:

​1693057Trac #27667: remove todo
​a21c793Trac #27667: realign doctest output

comment:6 in reply to: ↑ 5 Changed 2 years ago by dkrenn

Replying to dkrenn:

​1693057Trac #27667: remove todo

Py2/3-todo removed as this is solved now, right? (needs cross-review)

​a21c793Trac #27667: realign doctest output

I've realigned some of the changed doctest output lines; this should have no impact.

comment:7 Changed 2 years ago by chapoton

looks good to me. You can set to positive if you agree

comment:8 Changed 2 years ago by dkrenn

  • Status changed from needs_review to positive_review

comment:9 Changed 2 years ago by vbraun

  • Branch changed from u/dkrenn/27667 to a21c79309c67c4fe9ab130c35a70825fb4aa8136
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.