Opened 3 years ago
Closed 3 years ago
#27661 closed enhancement (fixed)
cleanup of modular/dims.py
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.8 |
Component: | modular forms | Keywords: | |
Cc: | tscrim, jmantysalo | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 6cc746b (Commits, GitHub, GitLab) | Commit: | 6cc746b26c4fe9d97e980c94f4df9a7e8e9cc113 |
Dependencies: | Stopgaps: |
Description
only details, code and doc refreshing
Change History (7)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/27661
- Commit set to 6c3e848c510a671fbaa6384b059203e62ec3481c
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Reviewers set to Travis Scrimshaw
Since you are cleaning this: in the *prod([list comp])
, you can remove the list creation (K.prod(foo for foo in bar)
works).
Another while-we-are-at-it thing: error messages starting with lowercase letters.
Thank you for doing all this cleaning. :)
comment:4 Changed 3 years ago by
- Commit changed from 6c3e848c510a671fbaa6384b059203e62ec3481c to 6cc746b26c4fe9d97e980c94f4df9a7e8e9cc113
comment:5 Changed 3 years ago by
done, thx
comment:6 Changed 3 years ago by
- Status changed from needs_review to positive_review
Thank you. LGTM.
comment:7 Changed 3 years ago by
- Branch changed from u/chapoton/27661 to 6cc746b26c4fe9d97e980c94f4df9a7e8e9cc113
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
cleanup of the file modular/dims.py