Opened 4 years ago

Last modified 3 years ago

#27660 new enhancement

Replace sage.env._get_shared_lib_filename with sage.misc.compat.find_library

Reported by: Timo Kaufmann Owned by: Erik Bray
Priority: major Milestone:
Component: misc Keywords:
Cc: Erik Bray, Dima Pasechnik Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Continuation of #27230.

sage.env._get_shared_lib_filename tries to guess the location of a shared library. This broke tests on nix, even though the function is not even needed (since library locations are provided by env vars).

In contrast, sage.misc.compat.find_library seems to cover the same functionality but queries the system instead of trying to guess. It also provides a fallback through DYLD_LIBRARY_PATH.

Is there any reason we shouldn't completely remove the sage.env._get_shared_lib_filename function?

Change History (2)

comment:1 Changed 4 years ago by Erik Bray

Owner: set to Erik Bray

I'll look at this when I can.

comment:2 Changed 3 years ago by Erik Bray

Milestone: sage-8.8

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

Note: See TracTickets for help on using tickets.