Opened 2 years ago

Closed 2 years ago

#27658 closed defect (fixed)

Error in testing whether a scalar field belongs to a module of differential forms

Reported by: egourgoulhon Owned by:
Priority: major Milestone: sage-8.8
Component: geometry Keywords: differential forms, manifolds
Cc: gh-DeRhamSource Merged in:
Authors: Eric Gourgoulhon Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: df21950 (Commits, GitHub, GitLab) Commit: df21950187674305cca9ebfec4c0e3976eceffaa
Dependencies: Stopgaps:

Status badges

Description (last modified by egourgoulhon)

In Sage 8.8.beta1, as well as in Sage 8.6 and 8.7, we have 

sage: M = Manifold(2, 'M')
sage: X.<x,y> = M.chart()
sage: f = M.scalar_field(x)
sage: f in M.diff_form_module(0)  # OK
True
sage: f in M.diff_form_module(1)  # Bang!
...
AttributeError: 'list' object has no attribute '_sage_'

Full log is attached.

Attachments (1)

error.log​ (6.7 KB) - added by egourgoulhon 2 years ago.

Download all attachments as: .zip

Change History (10)

Changed 2 years ago by egourgoulhon

comment:1 Changed 2 years ago by egourgoulhon

  • Description modified (diff)

comment:2 Changed 2 years ago by gh-DeRhamSource

  • Cc gh-DeRhamSource added

comment:3 Changed 2 years ago by egourgoulhon

  • Branch set to public/manifolds/fix_bug_27658
  • Commit set to d97d6652fba5cdfe8c61368ae12b8d3d1eaec761
  • Status changed from new to needs_review

Please review.

New commits:

​d97d665Fix coercion of scalar fields in modules of differential forms (trac #27658)

comment:4 follow-up: Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

#27658 -> :trac:`27658` and author name => positive review.

comment:5 Changed 2 years ago by git

  • Commit changed from d97d6652fba5cdfe8c61368ae12b8d3d1eaec761 to df21950187674305cca9ebfec4c0e3976eceffaa

Branch pushed to git repo; I updated commit sha1. New commits:

​df21950Fix reference to Trac ticket in doctest

comment:6 Changed 2 years ago by egourgoulhon

  • Authors set to Eric Gourgoulhon

comment:7 in reply to: ↑ 4 Changed 2 years ago by egourgoulhon

Replying to tscrim:

#27658 -> :trac:`27658` and author name => positive review.

Is it OK for you?

comment:8 Changed 2 years ago by tscrim

  • Status changed from needs_review to positive_review

Yep, that is great. Thanks.

comment:9 Changed 2 years ago by vbraun

  • Branch changed from public/manifolds/fix_bug_27658 to df21950187674305cca9ebfec4c0e3976eceffaa
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.