Opened 7 months ago

Closed 7 months ago

#27653 closed enhancement (fixed)

Update sympy to 1.4

Reported by: arojas Owned by:
Priority: major Milestone: sage-8.8
Component: packages: standard Keywords: upgrade, sympy
Cc: fbissey, gh-timokau, jdemeyer, saraedum, slelievre Merged in:
Authors: Antonio Rojas Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3277ba7 (Commits) Commit: 3277ba76d0ba7174608a31a0c6623e9210c63e3d
Dependencies: Stopgaps:

Description (last modified by arojas)

Some tests need to be adjusted for minor changes in output syntax

Tarball: ​https://github.com/sympy/sympy/releases/download/sympy-1.4/sympy-1.4.tar.gz

Change History (7)

comment:1 Changed 7 months ago by arojas

  • Branch set to u/arojas/update_sympy_to_1_4

comment:2 Changed 7 months ago by arojas

  • Authors set to Antonio Rojas
  • Cc fbissey gh-timokau jdemeyer saraedum added
  • Commit set to 3277ba76d0ba7174608a31a0c6623e9210c63e3d
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

​0c715eaUpdate sympy to 1.4
​3277ba7Adjust doctests for sympy 1.4 output syntax changes

comment:3 Changed 7 months ago by slelievre

  • Cc slelievre added
  • Keywords upgrade sympy added

comment:4 Changed 7 months ago by dimpase

This looks strange to me: 

 --- a/sympy/core/function.py
 +++ b/sympy/core/function.py
-@@ -771,6 +771,16 @@ def _sage_(self):
-         func = sage.function(fname)(*args)
-         return func
+@@ -856,6 +856,16 @@ def _sage_(self):
+         return True
+

Care to explain what's happening here?

comment:5 Changed 7 months ago by fbissey

This is just a rebasing of the patch. The full patch is here ​https://git.sagemath.org/sage.git/tree/build/pkgs/sympy/patches/03_undeffun_sage.patch?id=204b3bed466f13805d903ed4fc5dbb142089c6e8

I guess the old patch had one less blank line.

comment:6 Changed 7 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. It is off to the buildbots now.

comment:7 Changed 7 months ago by vbraun

  • Branch changed from u/arojas/update_sympy_to_1_4 to 3277ba76d0ba7174608a31a0c6623e9210c63e3d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.