Opened 12 months ago

Closed 12 months ago

#27648 closed enhancement (fixed)

cleanup the file search.pyx

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.8
Component: misc Keywords:
Cc: tscrim, vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 899b4bc (Commits) Commit: 899b4bcf958df2843ceefa9595c42fe9ef9e4660
Dependencies: Stopgaps:

Description

adding doctests

Change History (9)

comment:1 Changed 12 months ago by chapoton

  • Branch set to u/chapoton/27648
  • Status changed from new to needs_review

comment:2 Changed 12 months ago by git

  • Commit set to 5879537ef7f0a2a3a79e0c8fed51eeacd061ada5

Branch pushed to git repo; I updated commit sha1. New commits:

​5879537cleanup the file src/sage/misc/search.pyx

comment:3 Changed 12 months ago by chapoton

  • Status changed from needs_review to needs_work

does not build

comment:4 Changed 12 months ago by git

  • Commit changed from 5879537ef7f0a2a3a79e0c8fed51eeacd061ada5 to 899b4bcf958df2843ceefa9595c42fe9ef9e4660

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​899b4bccleanup the file src/sage/misc/search.pyx

comment:5 Changed 12 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:6 Changed 12 months ago by chapoton

  • Cc tscrim vklein added

green bot, please review

comment:7 Changed 12 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 12 months ago by chapoton

Thanks a lot again for your many fast reviews, Travis.

comment:9 Changed 12 months ago by vbraun

  • Branch changed from u/chapoton/27648 to 899b4bcf958df2843ceefa9595c42fe9ef9e4660
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.