Opened 3 years ago

Closed 3 years ago

#27630 closed enhancement (fixed)

Py3 : Fix failures in src.sage.symbolic.constants

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3bc7b45 (Commits, GitHub, GitLab) Commit: 3bc7b45f5f19adcf794ec589edd1cfcf61a9618b
Dependencies: Stopgaps:

Status badges

Description (last modified by vklein)

Fix current python3 failures in src.sage.symbolic.constants. It's a simple str/char case.
constants_name_table use str as key and py_get_constant has a 'byte/str' input causing the constant to not be found in python3.

Change History (6)

comment:1 Changed 3 years ago by vklein

  • Description modified (diff)

comment:2 Changed 3 years ago by vklein

  • Description modified (diff)

comment:3 Changed 3 years ago by vklein

  • Branch set to u/vklein/27630

comment:4 Changed 3 years ago by vklein

  • Commit set to 3bc7b45f5f19adcf794ec589edd1cfcf61a9618b
  • Status changed from new to needs_review

New commits:

3bc7b45Trac 27630: Modify py_get_constant to be compa...

comment:5 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thx

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/vklein/27630 to 3bc7b45f5f19adcf794ec589edd1cfcf61a9618b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.