Opened 2 years ago

Closed 2 years ago

#27629 closed defect (fixed)

Broken comparison of symbolic matrix with assumptions

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.8
Component: symbolics Keywords:
Cc: bpage Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 66a8a4c (Commits, GitHub, GitLab) Commit: 66a8a4c3b3dd696c3ab6d9abc34654c4f309b7cd
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer) 

sage: assume(x,'real')
sage: e1 = matrix([[0,-x],[x,0]])
sage: e1.transpose() == e1
True

Clearly, the matrix should not be equal to its transpose!

Change History (7)

comment:1 Changed 2 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 2 years ago by bpage

  • Cc bpage added

comment:3 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/broken_comparison_of_symbolic_matrix_with_assumptions

comment:4 Changed 2 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 66a8a4c3b3dd696c3ab6d9abc34654c4f309b7cd
  • Status changed from new to needs_review

New commits:

​66a8a4cUse richcmp_item() to implement comparisons of matrices

comment:5 Changed 2 years ago by chapoton

looks good, but not clear why it was failing before..

comment:6 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, well..

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/broken_comparison_of_symbolic_matrix_with_assumptions to 66a8a4c3b3dd696c3ab6d9abc34654c4f309b7cd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.