Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#27617 closed enhancement (fixed)

fix a code typo in factorization_integer

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.8
Component: refactoring Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 17461cd (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

found by lgtm

Change History (6)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27617
  • Commit set to 17461cd10513b0af3738f38d4037daa71b978bb5
  • Status changed from new to needs_review

New commits:

​17461cdfix a code typo in factorization_integer (thx lgtm)

comment:2 Changed 2 years ago by chapoton

  • Cc tscrim jmantysalo added

green bot, please review

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27617 to 17461cd10513b0af3738f38d4037daa71b978bb5
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 2 years ago by slelievre

  • Commit 17461cd10513b0af3738f38d4037daa71b978bb5 deleted

comment:6 Changed 2 years ago by slelievre

  • Description modified (diff)

I guess this 

if key is not None:
    self.__x.sort(key=key)
else:
    self.__x.sort()

could be simplified to 

self.__x.sort(key=key)

but it's also fine as it is.

Note: See TracTickets for help on using tickets.