#27617 closed enhancement (fixed)
fix a code typo in factorization_integer
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.8 |
Component: | refactoring | Keywords: | |
Cc: | tscrim, jmantysalo | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 17461cd (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
found by lgtm
Change History (6)
comment:1 Changed 4 years ago by
Branch: | → u/chapoton/27617 |
---|---|
Commit: | → 17461cd10513b0af3738f38d4037daa71b978bb5 |
Status: | new → needs_review |
comment:3 Changed 4 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
LGTM.
comment:4 Changed 4 years ago by
Branch: | u/chapoton/27617 → 17461cd10513b0af3738f38d4037daa71b978bb5 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:5 Changed 4 years ago by
Commit: | 17461cd10513b0af3738f38d4037daa71b978bb5 |
---|
comment:6 Changed 4 years ago by
Description: | modified (diff) |
---|
I guess this
if key is not None: self.__x.sort(key=key) else: self.__x.sort()
could be simplified to
self.__x.sort(key=key)
but it's also fine as it is.
Note: See
TracTickets for help on using
tickets.
New commits:
fix a code typo in factorization_integer (thx lgtm)