Opened 3 years ago

Closed 3 years ago

#27614 closed enhancement (fixed)

py3: more fixes in numerical

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: vklein, jhpalmieri, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 0321343 (Commits, GitHub, GitLab) Commit: 0321343e2b53145269aaceeeb8aa28ec308c6ea7
Dependencies: Stopgaps:

Status badges

Description

by using N instead of round

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27614
  • Commit set to 0321343e2b53145269aaceeeb8aa28ec308c6ea7
  • Status changed from new to needs_review

New commits:

​0321343py3: some fixes in numerical by using N() instead of round()

comment:2 Changed 3 years ago by chapoton

  • Cc jhpalmieri tscrim added

green bot, please review

comment:3 Changed 3 years ago by slelievre

Maybe add spaces after commas (PEP8) while you're at it? ie replace: 

,digits=
, digits=

comment:4 Changed 3 years ago by chapoton

Please spare my time. Pep8 is for the code, not for the documentation.

comment:5 Changed 3 years ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

IMHO if pep8 is a good practice for the code, i don't see why it wouldn't be pertinent in the documentation. Especially in the examples where it make sense to promote good coding practice.

That being said that's not this ticket goal.

Looks good to me.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27614 to 0321343e2b53145269aaceeeb8aa28ec308c6ea7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.