Opened 7 months ago

Closed 7 months ago

Last modified 6 months ago

#27612 closed defect (fixed)

Py3 doctests in padic_lattice_element.py

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-8.8
Component: python3 Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 0dba3b0 (Commits) Commit:
Dependencies: Stopgaps:

Description

Fix the Python 3 doctests in this file.

Change History (7)

comment:1 Changed 7 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/lattice_element

comment:2 Changed 7 months ago by jhpalmieri

  • Commit set to 0dba3b0d32d2c683d3a07b1dd6b4cc7a08400285
  • Status changed from new to needs_review

New commits:

0dba3b0trac 27612: Fix Python 3 doctests for padic_lattice_element.py

comment:3 Changed 7 months ago by jhpalmieri

For reasons I don't understand (see https://groups.google.com/d/msg/sage-devel/r7Q7XpL_bgY/1P7BOYzNBgAJ), with Python 2, the different functions ZpLC(2), ZpLF(2), and a few others all produce deprecation warnings when run at the command line, but there is just a single deprecation warning (printed for the first function and not the rest) when running doctests. With Python 3, the behavior is the same for doctests and at the command line.

Last edited 7 months ago by jhpalmieri (previous) (diff)

comment:4 Changed 7 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good enough for the moment, even if it only cures symptoms

comment:5 Changed 7 months ago by vbraun

  • Branch changed from u/jhpalmieri/lattice_element to 0dba3b0d32d2c683d3a07b1dd6b4cc7a08400285
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 6 months ago by jhpalmieri

  • Commit 0dba3b0d32d2c683d3a07b1dd6b4cc7a08400285 deleted

Do we need to undo this change? This is now failing for me, maybe because of the upgrade in the version of Python 3.

comment:7 Changed 6 months ago by jhpalmieri

Never mind, it's working for me now. I don't know what was going on before.

Note: See TracTickets for help on using tickets.