Opened 3 years ago

Closed 3 years ago

#27597 closed defect (fixed)

igraph requires -lblas and -llapack

Reported by: jdemeyer Owned by: dimpase
Priority: blocker Milestone: sage-8.8
Component: packages: optional Keywords:
Cc: dimpase Merged in:
Authors: Dima Pasechnik Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 28d375f (Commits, GitHub, GitLab) Commit: 28d375fc06ce45866233da4fbe1c239909312875
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

igraph doesn't build on some systems:

[igraph-0.7.1999] /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lblas
[igraph-0.7.1999] /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -llapack

Ideally, it should use OpenBLAS but it doesn't. Note that linking against OpenBLAS should be done with -lopenblas, not -lblas.

The use of blas/lapack in the (new) igraph is optional, so we just not use them in this branch.

We also specify the required in the (new) igraph package glpk in its dependencies.

Change History (8)

comment:1 Changed 3 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Owner changed from (none) to dimpase

in fact, it's entirely a bug introduced by me. The have very similar options --with-glpk=external, --with-blas=external, meaning totally different things---cause they ship a version of glpk, but do not ship one for blas/lapack, which are actually optional.

So we should not link them at all (I won't try making an openblas version, I have no idea whether it's supported).

comment:2 Changed 3 years ago by chapoton

This should be fixed as soon as possible, as it causes the patchbot sage4 to pollute every ticket with a wrong report.

comment:3 Changed 3 years ago by dimpase

  • Branch set to u/dimpase/packages/igraph_noblas
  • Commit set to 37ccc83adced0c3daaff912bd87fc6bcb3cca2fd

comment:4 Changed 3 years ago by jdemeyer

What about GLPK? If you want to use the GLPK in Sage, there should be a dependency on it.

comment:5 Changed 3 years ago by git

  • Commit changed from 37ccc83adced0c3daaff912bd87fc6bcb3cca2fd to 28d375fc06ce45866233da4fbe1c239909312875

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

28d375fdo not use blas/lapack with igraph

comment:6 Changed 3 years ago by dimpase

  • Description modified (diff)
  • Status changed from new to needs_review

comment:7 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

Green bot on sage4. Thanks!

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/packages/igraph_noblas to 28d375fc06ce45866233da4fbe1c239909312875
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.