Opened 2 years ago

Closed 2 years ago

#27590 closed enhancement (fixed)

fixing various details in elliptic curves

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: elliptic curves Keywords:
Cc: cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 938505b (Commits, GitHub, GitLab) Commit: 938505bc1644e461d39c7a72431d36c5a2881ba3
Dependencies: Stopgaps:

Status badges

Description

including some lgtm warnings

Change History (6)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27590
  • Commit set to 266488937722ef2c93e9e42e718e69f906528a93
  • Status changed from new to needs_review

New commits:

2664889fixing various details in elliptic_curves

comment:2 Changed 2 years ago by cremona

Code changes all look good to me. I learned a few things! I did not know that you could do QQ.prod(), and also that 'x not in S' was valid instead of 'not x in S'.

The patchbot error is something completely irrelevant (building igraph). So I will run tests myself.

LGTM seems very good. I just completed the job of achieving 100% on eclib, but sage has 5.4k alerts to look into...

comment:3 Changed 2 years ago by git

  • Commit changed from 266488937722ef2c93e9e42e718e69f906528a93 to 938505bc1644e461d39c7a72431d36c5a2881ba3

Branch pushed to git repo; I updated commit sha1. New commits:

938505btrac 27590 fixing the class in weierstrass_morphism

comment:4 Changed 2 years ago by chapoton

My bot is now green (python2). I had only checked with python3, not seeing an issue with old-style class.

comment:5 Changed 2 years ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

I never got to manual testing for the usual reasons (it took an age to build and then dochtml failed for no good reason). Since the bot is green anyway, I am happy.

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27590 to 938505bc1644e461d39c7a72431d36c5a2881ba3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.