Opened 2 years ago

Closed 2 years ago

#27577 closed defect (fixed)

add conversion of abs back from fricas

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: interfaces: optional Keywords: FriCAS
Cc: mantepse, rws Merged in:
Authors: Frédéric Chapoton Reviewers: Martin Rubey
Report Upstream: N/A Work issues:
Branch: 2b35b3b (Commits, GitHub, GitLab) Commit: 2b35b3b2fccdbc3eedda5b7f0a57d5da08de135c
Dependencies: Stopgaps:

Status badges

Description (last modified by charpent)

When Fricas uses abs() in its return value, this function is translated back to sage as a new symbolic, unevaluable function. See this sage-devel post for illustration.

Change History (7)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27577
  • Commit set to 2b35b3b2fccdbc3eedda5b7f0a57d5da08de135c
  • Status changed from new to needs_review

New commits:

2b35b3badd abs conversion back from Fricas

comment:2 Changed 2 years ago by mantepse

  • Keywords FriCAS added

comment:3 Changed 2 years ago by mantepse

  • Status changed from needs_review to positive_review

Looks good!

comment:4 Changed 2 years ago by chapoton

Thx. reviewer name, please

comment:5 Changed 2 years ago by charpent

  • Description modified (diff)
  • Type changed from enhancement to defect

Added a bit of description.

Thanks !

comment:6 Changed 2 years ago by chapoton

  • Reviewers set to Martin Rubey

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27577 to 2b35b3b2fccdbc3eedda5b7f0a57d5da08de135c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.