Opened 18 months ago

Last modified 18 months ago

#27575 closed defect

Three.js: Fix CDN Fallback — at Version 7

Reported by: paulmasson Owned by:
Priority: major Milestone: sage-8.8
Component: graphics Keywords: threejs
Cc: egourgoulhon, novoselt, slelievre Merged in:
Authors: Paul Masson Reviewers:
Report Upstream: N/A Work issues:
Branch: u/paulmasson/three_js__fix_cdn_fallback Commit: 9a81aedc9a591d8ca64605ad2fab601d70609735
Dependencies: Stopgaps:

Description (last modified by paulmasson)

The Three.js viewer for notebooks already had a fallback to the online CDN when the local files are not loaded, which was silently failing. This small change fixes that.

Renders this discussion moot.

Change History (7)

comment:1 Changed 18 months ago by paulmasson

  • Branch set to u/paulmasson/three_js__fix_cdn_fallback

comment:2 Changed 18 months ago by paulmasson

  • Authors set to Paul Masson
  • Cc egourgoulhon novoselt added
  • Commit set to 378512d2fb497c4297895ae9386afe862a26249b
  • Component changed from PLEASE CHANGE to graphics
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

378512dFix CDN fallback

comment:3 Changed 18 months ago by dimpase

The "mooted" discussion is about such a fallback should be on by default. Do I get it right that the fallback was simply broken, and the branch here fixes it, so that it silently works?

comment:4 Changed 18 months ago by saraedum

Could you explain why this makes a difference? I.e., I don't understand why this change would make a difference to the browser.

Also, how does this compare to https://trac.sagemath.org/ticket/26434?

Last edited 18 months ago by saraedum (previous) (diff)

comment:5 Changed 18 months ago by saraedum

I thought I had understood, but I think I don't. The online scripts don't seem to contain a '. So why did it not work before?

Last edited 18 months ago by saraedum (previous) (diff)

comment:6 Changed 18 months ago by git

  • Commit changed from 378512d2fb497c4297895ae9386afe862a26249b to 9a81aedc9a591d8ca64605ad2fab601d70609735

Branch pushed to git repo; I updated commit sha1. New commits:

9a81aedFix CDN fallback

comment:7 Changed 18 months ago by paulmasson

  • Description modified (diff)
Note: See TracTickets for help on using tickets.