Opened 18 months ago

Last modified 18 months ago

#27575 closed defect

Three.js: Fix CDN Fallback — at Version 2

Reported by: paulmasson Owned by:
Priority: major Milestone: sage-8.8
Component: graphics Keywords: threejs
Cc: egourgoulhon, novoselt, slelievre Merged in:
Authors: Paul Masson Reviewers:
Report Upstream: N/A Work issues:
Branch: u/paulmasson/three_js__fix_cdn_fallback Commit: 378512d2fb497c4297895ae9386afe862a26249b
Dependencies: Stopgaps:

Description (last modified by paulmasson)

The Three.js viewer for notebooks already had a fallback to the online CDN when the local files are not loaded which was silently failing. This small change fixes that for most browsers, but it will not work for Internet Explorer. The fix to cover this old browser would be much more clumsy and not encourage users to move to better browser options.

Renders this discussion moot.

Change History (2)

comment:1 Changed 18 months ago by paulmasson

  • Branch set to u/paulmasson/three_js__fix_cdn_fallback

comment:2 Changed 18 months ago by paulmasson

  • Authors set to Paul Masson
  • Cc egourgoulhon novoselt added
  • Commit set to 378512d2fb497c4297895ae9386afe862a26249b
  • Component changed from PLEASE CHANGE to graphics
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

378512dFix CDN fallback
Note: See TracTickets for help on using tickets.