Changes between Initial Version and Version 2 of Ticket #27575


Ignore:
Timestamp:
03/30/19 19:54:23 (17 months ago)
Author:
paulmasson
Comment:

New commits:

378512dFix CDN fallback

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27575

    • Property Status changed from new to needs_review
    • Property Authors changed from to Paul Masson
    • Property Cc egourgoulhon novoselt added
    • Property Component changed from PLEASE CHANGE to graphics
    • Property Branch changed from to u/paulmasson/three_js__fix_cdn_fallback
    • Property Commit changed from to 378512d2fb497c4297895ae9386afe862a26249b
    • Property Type changed from PLEASE CHANGE to defect
  • Ticket #27575 – Description

    initial v2  
     1The Three.js viewer for notebooks already had a fallback to the online CDN when the local files are not loaded which was silently failing. This small change fixes that for most browsers, but it will not work for Internet Explorer. The fix to cover this old browser would be much more clumsy and not encourage users to move to better browser options.
     2
     3Renders [https://groups.google.com/forum/?nomobile=true#!topic/sage-devel/QC5-9rexyJo this discussion] moot.