Opened 3 years ago

Closed 3 years ago

#27561 closed defect (fixed)

Fix Minor Three.js Template Error

Reported by: paulmasson Owned by:
Priority: minor Milestone: sage-8.8
Component: graphics Keywords: threejs
Cc: egourgoulhon Merged in:
Authors: Paul Masson Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 7d49fb5 (Commits, GitHub, GitLab) Commit: 7d49fb522fdd4e0b27ed642a993e5ec9e9f0ece2
Dependencies: Stopgaps:

Status badges

Description


Change History (4)

comment:1 Changed 3 years ago by paulmasson

  • Branch set to u/paulmasson/fix_minor_three_js_template_error

comment:2 Changed 3 years ago by paulmasson

  • Authors set to Paul Masson
  • Cc egourgoulhon added
  • Commit set to 7d49fb522fdd4e0b27ed642a993e5ec9e9f0ece2
  • Component changed from PLEASE CHANGE to graphics
  • Priority changed from major to minor
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

The variable rRange is used for automatic resizing of the vertical aspect of the plot. Clearly it should be calculated using both x and y coordinates. This commit fixes that.


New commits:

7d49fb5Both x and y in radial range

comment:3 Changed 3 years ago by egourgoulhon

  • Keywords threejs added
  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

Thanks for the fix! LGTM.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/paulmasson/fix_minor_three_js_template_error to 7d49fb522fdd4e0b27ed642a993e5ec9e9f0ece2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.