Opened 3 years ago

Closed 3 years ago

#27547 closed enhancement (fixed)

Improve one plot error message

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-8.8
Component: graphics Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 59f2a24 (Commits, GitHub, GitLab) Commit: 59f2a244b06fbdae479abf824f42324673e1f0ff
Dependencies: Stopgaps:

Status badges


In this ask.sagemath question, one user is confused because of the error message "Some variable ranges specify variables while others do not", which occurs in plotting when you use arguments like (x, 0, 1) together with (0, 2). But it just checks to see if the ranges have different lengths, it doesn't first check to see if any of the ranges don't make any sense at all, like (x, -0,5, 1.5) (the comma in "-0,5" should be a period, but since it's not, the tuple has length 4).

Change History (4)

comment:1 Changed 3 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/plot-error-message

comment:2 Changed 3 years ago by jhpalmieri

  • Commit set to 59f2a244b06fbdae479abf824f42324673e1f0ff
  • Status changed from new to needs_review

New commits:

59f2a24trac 27547: improve one error message in plot/misc,

comment:3 Changed 3 years ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

LGTM. Thanks!

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/jhpalmieri/plot-error-message to 59f2a244b06fbdae479abf824f42324673e1f0ff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.