Opened 4 years ago

Closed 3 years ago

#27545 closed defect (fixed)

py3: cluster_algebra_quiver pickle depends on Python version

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: Frédéric Chapoton, Erik Bray Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a16ae1f (Commits, GitHub, GitLab) Commit: a16ae1f51045d094441c4f9ee9b6d7ef1ef9afad
Dependencies: Stopgaps:

Status badges

Description

The pickle cluster_algebra_quiver/mutation_classes_%s.dig6 currently depends on the Python version: pickles created with Python 3 cannot be opened with Python 2.

There are multiple solutions to this, such as ensuring that a pickle is always stored in a compatible version. But since these pickles are optional, a simpler solution is simply ignoring unpickling errors.

Change History (5)

comment:1 Changed 4 years ago by Jeroen Demeyer

Branch: u/jdemeyer/py3__cluster_algebra_quiver_pickle_depends_on_python_version

comment:2 Changed 4 years ago by Jeroen Demeyer

Commit: a16ae1f51045d094441c4f9ee9b6d7ef1ef9afad
Status: newneeds_review

New commits:

a16ae1fIgnore all errors while unpickling cluster_algebra_quiver pickle

comment:3 Changed 4 years ago by Erik Bray

This has been a frequent source of annoyance for me as well. Personally I would prefer to have different versions of the file depending on the Python version. But at the same time most users won't be using Python 2 Sage and Python 3 Sage together on the same system, and even if we did do that, ignoring unpickle errors here would still be desirable. This is just a cache and regenerating the cache if needed is no big deal since it does not take so long.

comment:4 Changed 3 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, thx

comment:5 Changed 3 years ago by Volker Braun

Branch: u/jdemeyer/py3__cluster_algebra_quiver_pickle_depends_on_python_versiona16ae1f51045d094441c4f9ee9b6d7ef1ef9afad
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.