Changes between Initial Version and Version 12 of Ticket #27539


Ignore:
Timestamp:
03/27/19 19:06:41 (14 months ago)
Author:
embray
Comment:

I ran the tests for this sub-package on an older Python 3 build and had two test failures, one of which was obviously the one that this ticket was intended to fix, so I have updated the description with that additional info.

The question you have to ask is why does this fail on Python 3 but not on Python 2? I've spent a bit of time looking into it and this is still not entirely clear to me. This may well be the simplest and most obvious solution, and I have no problem with it on its face. I'm just a little unsettled by not knowing why this worked before and now doesn't (even with the same pickle protocol it fails).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27539

    • Property Status changed from new to closed
    • Property Cc embray jdemeyer tscrim added
    • Property Summary changed from py3: add _reduce__ to eclib modular symbol to py3: add __reduce__ to eclib modular symbol
    • Property Branch changed from to 600d921515514ee9c74eb0cd68c69ea68f72ffca
    • Property Reviewers changed from to Travis Scrimshaw
    • Property Owner changed from (none) to chapoton
    • Property Resolution changed from to fixed
  • Ticket #27539 – Description

    initial v12  
    1 to fix the last doctest in schemes/elliptic_curves/
     1to fix the last doctest in schemes/elliptic_curves/:
     2
     3{{{
     4sage -t --long src/sage/schemes/elliptic_curves/padic_lseries.py
     5**********************************************************************
     6File "src/sage/schemes/elliptic_curves/padic_lseries.py", line 155, in sage.schemes.elliptic_curves.padic_lseries.pAdicLseries
     7Failed example:
     8    lp == loads(dumps(lp))
     9Exception raised:
     10    Traceback (most recent call last):
     11      File "sage/misc/persist.pyx", line 284, in sage.misc.persist.dumps (build/cythonized/sage/misc/persist.c:4158)
     12        return obj.dumps(compress)
     13      File "sage/structure/sage_object.pyx", line 464, in sage.structure.sage_object.SageObject.dumps (build/cythonized/sage/structure/sage_object.c:3645)
     14        return _base_dumps(self, compress=compress)
     15      File "sage/misc/persist.pyx", line 257, in sage.misc.persist._base_dumps (build/cythonized/sage/misc/persist.c:3892)
     16        gherkin = SagePickler.dumps(obj)
     17      File "sage/misc/persist.pyx", line 836, in sage.misc.persist.SagePickler.dumps (build/cythonized/sage/misc/persist.c:6607)
     18        pickler.dump(obj)
     19    TypeError: can't pickle sage.libs.eclib.newforms.ECModularSymbol objects
     20
     21    During handling of the above exception, another exception occurred:
     22
     23    Traceback (most recent call last):
     24      File "/home/embray/src/sagemath/sage-python3/local/lib/python3.6/site-packages/sage/doctest/forker.py", line 671, in _run
     25        self.compile_and_execute(example, compiler, test.globs)
     26      File "/home/embray/src/sagemath/sage-python3/local/lib/python3.6/site-packages/sage/doctest/forker.py", line 1095, in compile_and_execute
     27        exec(compiled, globs)
     28      File "<doctest sage.schemes.elliptic_curves.padic_lseries.pAdicLseries[18]>", line 1, in <module>
     29        lp == loads(dumps(lp))
     30      File "sage/misc/persist.pyx", line 286, in sage.misc.persist.dumps (build/cythonized/sage/misc/persist.c:4211)
     31        return _base_dumps(obj, compress=compress)
     32      File "sage/misc/persist.pyx", line 257, in sage.misc.persist._base_dumps (build/cythonized/sage/misc/persist.c:3892)
     33        gherkin = SagePickler.dumps(obj)
     34      File "sage/misc/persist.pyx", line 836, in sage.misc.persist.SagePickler.dumps (build/cythonized/sage/misc/persist.c:6607)
     35        pickler.dump(obj)
     36    TypeError: can't pickle sage.libs.eclib.newforms.ECModularSymbol objects
     37**********************************************************************
     381 item had failures:
     39   1 of  20 in sage.schemes.elliptic_curves.padic_lseries.pAdicLseries
     40    [216 tests, 1 failure, 19.32 s]
     41}}}