Opened 4 years ago

Closed 4 years ago

#27535 closed enhancement (fixed)

adding a small knot database

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: algebraic topology Keywords: knot
Cc: Travis Scrimshaw, Miguel Marco Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 10aa203 (Commits, GitHub, GitLab) Commit: 10aa203846a213e3574584460caadceede11d572
Dependencies: Stopgaps:

Status badges

Description


Change History (20)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: u/chapoton/27535
Commit: c7f42ffe07074742b632a3e0fc671904b6242e5b

work in progress


New commits:

c7f42fftrying to add one knot database

comment:2 Changed 4 years ago by git

Commit: c7f42ffe07074742b632a3e0fc671904b6242e5bfde13308ff803caa000d2c416e198ba215a79d4d

Branch pushed to git repo; I updated commit sha1. New commits:

fde1330trac 27535 some more work on small knots table

comment:3 Changed 4 years ago by git

Commit: fde13308ff803caa000d2c416e198ba215a79d4d56678bd2bdeef1b79d15a704a0d916f5d6a7966f

Branch pushed to git repo; I updated commit sha1. New commits:

56678bdfix

comment:4 Changed 4 years ago by git

Commit: 56678bd2bdeef1b79d15a704a0d916f5d6a7966f2b7adf3829b3992a1100826533d49a76e10c98cb

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2b7adf3adding a small-knots database

comment:5 Changed 4 years ago by Travis Scrimshaw

Cc: Travis Scrimshaw added

+1

comment:6 Changed 4 years ago by git

Commit: 2b7adf3829b3992a1100826533d49a76e10c98cb3f4908f251af72b6214bc511a11bb98fa0531f80

Branch pushed to git repo; I updated commit sha1. New commits:

3f4908ftrac 27535 some details about knot table

comment:7 Changed 4 years ago by git

Commit: 3f4908f251af72b6214bc511a11bb98fa0531f80ac29a792dd951226ac8a3fed31cb0c548b1da422

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ac29a79adding a small-knots database

comment:8 Changed 4 years ago by git

Commit: ac29a792dd951226ac8a3fed31cb0c548b1da422a0897a36fa8c5eaee4804280c4733c4c910fa8ab

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a0897a3adding a small-knots database

comment:9 Changed 4 years ago by Frédéric Chapoton

Status: newneeds_review

Please have a look.

comment:10 Changed 4 years ago by Frédéric Chapoton

Cc: Miguel Marco added

comment:11 Changed 4 years ago by Frédéric Chapoton

Keywords: knot added

comment:12 Changed 4 years ago by Miguel Marco

This is a nice addition!

How did you const6ruct the table of knots? Used some scripts to parse the data from the knot atlas?

comment:13 Changed 4 years ago by Frédéric Chapoton

Well, just taking the table and cleaning it by hand in emacs, using search-and-replace.

comment:14 Changed 4 years ago by Frédéric Chapoton

green bot

comment:15 Changed 4 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

I think this is a little misleading about the from_table input:

a pair of integers `(n, k)` where `n` is the crossing number

as it makes it seem like it should take a tuple. I think it would be better to have a more standard INPUT: block of

- ``n`` -- the crossing number
- ``k`` -- a positive integer

A little formatting thing, I think the first entry of the knot table should be on its own line instead of part of the small_knots_table = {. I would also indent all of them to make it clear they are enclosed in something.

Other than these two things, LGTM, and this will be a very nice addition to have.

comment:16 Changed 4 years ago by Travis Scrimshaw

Doing this for links might also be a good follow-up too based on this: http://katlas.org/wiki/The_Thistlethwaite_Link_Table

comment:17 Changed 4 years ago by git

Commit: a0897a36fa8c5eaee4804280c4733c4c910fa8ab10aa203846a213e3574584460caadceede11d572

Branch pushed to git repo; I updated commit sha1. New commits:

42d2d9bMerge branch 'u/chapoton/27535' into 8.8.b0
10aa203trac 27535 some details as suggested by reviewer

comment:18 Changed 4 years ago by Frédéric Chapoton

done, thx

comment:19 Changed 4 years ago by Travis Scrimshaw

Status: needs_reviewpositive_review

Thanks. LGTM.

comment:20 Changed 4 years ago by Volker Braun

Branch: u/chapoton/2753510aa203846a213e3574584460caadceede11d572
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.