Opened 4 years ago
Closed 4 years ago
#27535 closed enhancement (fixed)
adding a small knot database
Reported by:  Frédéric Chapoton  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  algebraic topology  Keywords:  knot 
Cc:  Travis Scrimshaw, Miguel Marco  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  10aa203 (Commits, GitHub, GitLab)  Commit:  10aa203846a213e3574584460caadceede11d572 
Dependencies:  Stopgaps: 
Description
Change History (20)
comment:1 Changed 4 years ago by
Branch:  → u/chapoton/27535 

Commit:  → c7f42ffe07074742b632a3e0fc671904b6242e5b 
comment:2 Changed 4 years ago by
Commit:  c7f42ffe07074742b632a3e0fc671904b6242e5b → fde13308ff803caa000d2c416e198ba215a79d4d 

Branch pushed to git repo; I updated commit sha1. New commits:
fde1330  trac 27535 some more work on small knots table

comment:3 Changed 4 years ago by
Commit:  fde13308ff803caa000d2c416e198ba215a79d4d → 56678bd2bdeef1b79d15a704a0d916f5d6a7966f 

Branch pushed to git repo; I updated commit sha1. New commits:
56678bd  fix

comment:4 Changed 4 years ago by
Commit:  56678bd2bdeef1b79d15a704a0d916f5d6a7966f → 2b7adf3829b3992a1100826533d49a76e10c98cb 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
2b7adf3  adding a smallknots database

comment:6 Changed 4 years ago by
Commit:  2b7adf3829b3992a1100826533d49a76e10c98cb → 3f4908f251af72b6214bc511a11bb98fa0531f80 

Branch pushed to git repo; I updated commit sha1. New commits:
3f4908f  trac 27535 some details about knot table

comment:7 Changed 4 years ago by
Commit:  3f4908f251af72b6214bc511a11bb98fa0531f80 → ac29a792dd951226ac8a3fed31cb0c548b1da422 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ac29a79  adding a smallknots database

comment:8 Changed 4 years ago by
Commit:  ac29a792dd951226ac8a3fed31cb0c548b1da422 → a0897a36fa8c5eaee4804280c4733c4c910fa8ab 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
a0897a3  adding a smallknots database

comment:10 Changed 4 years ago by
Cc:  Miguel Marco added 

comment:11 Changed 4 years ago by
Keywords:  knot added 

comment:12 Changed 4 years ago by
This is a nice addition!
How did you const6ruct the table of knots? Used some scripts to parse the data from the knot atlas?
comment:13 Changed 4 years ago by
Well, just taking the table and cleaning it by hand in emacs, using searchandreplace.
comment:15 Changed 4 years ago by
Reviewers:  → Travis Scrimshaw 

I think this is a little misleading about the from_table
input:
a pair of integers `(n, k)` where `n` is the crossing number
as it makes it seem like it should take a tuple. I think it would be better to have a more standard INPUT:
block of
 ``n``  the crossing number  ``k``  a positive integer
A little formatting thing, I think the first entry of the knot table should be on its own line instead of part of the small_knots_table = {
. I would also indent all of them to make it clear they are enclosed in something.
Other than these two things, LGTM, and this will be a very nice addition to have.
comment:16 Changed 4 years ago by
Doing this for links might also be a good followup too based on this: http://katlas.org/wiki/The_Thistlethwaite_Link_Table
comment:17 Changed 4 years ago by
Commit:  a0897a36fa8c5eaee4804280c4733c4c910fa8ab → 10aa203846a213e3574584460caadceede11d572 

comment:20 Changed 4 years ago by
Branch:  u/chapoton/27535 → 10aa203846a213e3574584460caadceede11d572 

Resolution:  → fixed 
Status:  positive_review → closed 
work in progress
New commits:
trying to add one knot database