Opened 2 years ago
Closed 2 years ago
#27520 closed enhancement (fixed)
py3: some care for reraise
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.8 |
Component: | python3 | Keywords: | |
Cc: | embray, jdemeyer | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | f92a70c (Commits, GitHub, GitLab) | Commit: | f92a70c226ea6bbba3cfb221c8cc7a5c294a9558 |
Dependencies: | Stopgaps: |
Description
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to u/chapoton/27520
- Commit set to 926f282d197c1cfc380128b8cceddf24caae9917
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
So there are some errors reported by the patchbot, but I am not sure if they are strictly due to this ticket.
Also, I bet you are probably doing things mechanically, but if len(foo) > 0:
-> if len(foo):
is better changed to if foo:
. ;)
comment:3 Changed 2 years ago by
- Commit changed from 926f282d197c1cfc380128b8cceddf24caae9917 to f92a70c226ea6bbba3cfb221c8cc7a5c294a9558
Branch pushed to git repo; I updated commit sha1. New commits:
f92a70c | trac 27520 some details
|
comment:4 Changed 2 years ago by
Thx, done. I am launching my own patchbot on that beast, now.
comment:5 Changed 2 years ago by
Apparently, the failures are unrelated. I forgot to fix all the len things.. Could we please skip that ?
comment:6 Changed 2 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Yep, that's fine. Thanks.
comment:7 Changed 2 years ago by
- Branch changed from u/chapoton/27520 to f92a70c226ea6bbba3cfb221c8cc7a5c294a9558
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3 some care for reraise