#27511 closed enhancement (fixed)

use sdh tools for normaliz

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.8
Component: packages: optional Keywords:
Cc: embray, jdemeyer, fbissey Merged in:
Authors: Frédéric Chapoton Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: eeaebe6 (Commits) Commit: eeaebe6c6e30e752085919535a028a2b1e42785b
Dependencies: Stopgaps:

Description


Change History (9)

comment:1 Changed 22 months ago by chapoton

  • Branch set to u/chapoton/27511
  • Cc embray added
  • Commit set to fade2fd80079784ebec18077338af3dd40bd2fd6
  • Status changed from new to needs_review

New commits:

fade2fduse sdh tools for normaliz

comment:2 Changed 22 months ago by chapoton

@embray, do you approve?

comment:3 Changed 22 months ago by chapoton

  • Cc jdemeyer fbissey added

someone, please review

comment:4 Changed 22 months ago by embray

  • Status changed from needs_review to needs_work

You can get rid of the explicit sdh_die calls since those are already built into sdh_make and sdh_make_install.

comment:5 Changed 22 months ago by git

  • Commit changed from fade2fd80079784ebec18077338af3dd40bd2fd6 to eeaebe6c6e30e752085919535a028a2b1e42785b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

eeaebe6use sdh tools for normaliz

comment:6 Changed 22 months ago by chapoton

done, thx

comment:7 Changed 22 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:8 Changed 22 months ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

Thank you!

comment:9 Changed 22 months ago by vbraun

  • Branch changed from u/chapoton/27511 to eeaebe6c6e30e752085919535a028a2b1e42785b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.