Opened 6 months ago

Closed 6 months ago

#27509 closed defect (fixed)

OpenBLAS 0.3.5 memory leak on Cygwin

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.8
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ee6e4a3 (Commits) Commit: ee6e4a3eb09aebc2ed9fe7959c4f997b5e75664f
Dependencies: Stopgaps:

Description (last modified by embray)

I discovered that part of the problem I've been having with OpenBLAS is that there is a pretty severe memory leak that gets worse any time an application with OpenBLAS loaded in it forks.

Upstream issue: https://github.com/xianyi/OpenBLAS/issues/2063

Upstream PR: https://github.com/xianyi/OpenBLAS/pull/2064

I already have a patch that I'll posting a PR for shortly, and would like to include in Sage. I'm just testing the patch now with Sage.

Change History (9)

comment:1 Changed 6 months ago by embray

  • Authors set to Erik Bray
  • Description modified (diff)

comment:2 Changed 6 months ago by embray

  • Description modified (diff)

comment:3 Changed 6 months ago by embray

  • Branch set to u/embray/ticket-27509
  • Commit set to ee6e4a3eb09aebc2ed9fe7959c4f997b5e75664f
  • Status changed from new to needs_review

If we can still have this one last patch applied for 8.7 that would be ideal, as this is a fairly bad issue. But it only especially becomes an issue when building and running the tests; probably less so in normal usage where running many subprocesses is slightly less common (except for some areas). I can possibly apply the patch and build openblas manually if absolute need be.


New commits:

ee6e4a3Trac #27509: Add patch from upstream pull request to fix memory leak on Cygwin

comment:4 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Accepted upstream, so good for Sage.

comment:5 Changed 6 months ago by vbraun

  • Priority changed from blocker to major

comment:6 Changed 6 months ago by embray

  • Priority changed from major to blocker

This is definitely a blocker.

comment:7 Changed 6 months ago by embray

If need be I can still do something manually, but as far as I'm concerned it's still a severe problem.

comment:8 Changed 6 months ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Moving all blocker/critical issues from 8.7 to 8.8.

comment:9 Changed 6 months ago by vbraun

  • Branch changed from u/embray/ticket-27509 to ee6e4a3eb09aebc2ed9fe7959c4f997b5e75664f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.