Opened 3 years ago

Closed 3 years ago

#27487 closed enhancement (fixed)

spkg-configure.m4 for cmake

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.8
Component: packages: optional Keywords:
Cc: embray, fbissey, slelievre, vklein Merged in:
Authors: Dima Pasechnik Reviewers: Erik Bray, Samuel Lelièvre, Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 741de68 (Commits, GitHub, GitLab) Commit: 741de682b235184c5562492d2e65c3bfc7a0add7
Dependencies: #27662 Stopgaps:

Status badges

Description

practically a copy of the one for patch

Change History (21)

comment:1 Changed 3 years ago by dimpase

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by embray

Well, this system's cmake is < 3.11, so in this case it "worked" in that it refused to use my system cmake. I don't know how strict the 3.11 requirement is but I'm fine with leaving it for now.

I'll also test on a system with a newer cmake.

comment:3 Changed 3 years ago by embray

Apparently 3.11 is actually quite recent. Unless there's a specific need for it, let's try setting to just 3.0 and see how that goes (my Cygwin has 3.83.6.2 for example).

Last edited 3 years ago by embray (previous) (diff)

comment:4 Changed 3 years ago by git

  • Commit changed from bd93208b2590259f62f19f22d2f0b157b0eefe38 to 07b87cf37a72d694bba703d538fd62b63931c289

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

07b87cfspkg-configure for cmake

comment:5 Changed 3 years ago by dimpase

OK, now it's 3.0.

comment:6 Changed 3 years ago by dimpase

Are you still checking this? There is an extra complication here that cmake keeps 3.x for long, issuing updates with numbers 3.x.y to them on a regular basis. Perhaps it's better to go all the way to x big enough for the meaningful cases such as current cygwin etc.

comment:7 Changed 3 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:8 Changed 3 years ago by slelievre

  • Cc fbissey slelievre vklein added

Note: we upgraded to cmake 3.11.0 in #25109 because cmake 3.8.1 was not enough to build primecount 4.3 (an optional package).

However, primecount 4.6 was released on 2019-04-13 and lowered the requirement from cmake 3.9 to cmake 3.4, if I understand correctly.

comment:9 Changed 3 years ago by slelievre

See the primecount changelog -- no tarball on the GitHub releases page yet.

Last edited 3 years ago by slelievre (previous) (diff)

comment:10 Changed 3 years ago by slelievre

Tarball now uploaded to GitHub. The upgrade to primecount 4.6 is tracked at #27662.

Consider cmake 3.4.3 (released 2016-01-25) rather than cmake 3.0.2 (released 2014-09-11).

comment:11 Changed 3 years ago by git

  • Commit changed from 07b87cf37a72d694bba703d538fd62b63931c289 to 741de682b235184c5562492d2e65c3bfc7a0add7

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

741de68spkg-configure for cmake

comment:12 Changed 3 years ago by dimpase

bumped up the minimal cmake version to 3.4. Please review.

comment:13 follow-up: Changed 3 years ago by embray

Okay, sounds good to me. Does this mean we still need to upgrade primecount though?

comment:14 in reply to: ↑ 13 Changed 3 years ago by vdelecroix

Replying to embray:

Okay, sounds good to me. Does this mean we still need to upgrade primecount though?

done at #27662

comment:15 Changed 3 years ago by dimpase

  • Dependencies set to #27662

comment:16 Changed 3 years ago by dimpase

To review:

  • pull the branch
  • make sure Sage's cmake is not installed. (make cmake-clean should do the job)
  • make sure you have cmake (version 3.4 or better) installed on the box.
  • run ./bootstrap (you nedd autotools, yes)
  • run ./configure and inspect its output - you should see that cmake is marked as `not installed)
  • to make sure this all works, try it on #27662 (or some other cmake-dependent Sage thing)

As this branch merely adds an spkg-configure.m4 file, there is no pressing need to have Sage's configure package updated. It will get in as soon as an update of the latter happens.

comment:17 Changed 3 years ago by vdelecroix

At least, cmake-3.14.1 is successfully detected on arch.

comment:18 Changed 3 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

And sage -i primecount did not trigger cmake compilation!

Thank you.

comment:19 Changed 3 years ago by dimpase

Thanks!

comment:20 Changed 3 years ago by slelievre

  • Reviewers changed from Vincent Delecroix to Erik Bray, Samuel Lelièvre, Vincent Delecroix

comment:21 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/packages/cmakeconf to 741de682b235184c5562492d2e65c3bfc7a0add7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.