Opened 2 years ago
Closed 2 years ago
#27465 closed defect (fixed)
py3: libs/ppl.pyx fixes
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.8 |
Component: | python3 | Keywords: | |
Cc: | chapoton | Merged in: | |
Authors: | John Palmieri | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 8d58a9a (Commits, GitHub, GitLab) | Commit: | 8d58a9add1be497fc44401b19472cdc4a967647a |
Dependencies: | Stopgaps: |
Description
In the output from the test_executable
function, it seems that Python 3 prints deprecation warnings after other output, whereas Python 2 prints it before other output. The branch here just adds py3
versions of the deprecation doctests in libs/ppl.pyx
.
Change History (7)
comment:1 Changed 2 years ago by
- Branch set to u/jhpalmieri/ppl-py3
comment:2 Changed 2 years ago by
- Commit set to 8d58a9add1be497fc44401b19472cdc4a967647a
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
I tried adding fflush(stderr)
in the various ascii_dump
functions, which I was hoping would unify the Python 2/3 output, but it didn't make any difference.
comment:4 Changed 2 years ago by
- Cc chapoton added
Frédéric, any thoughts on this?
The change LGTM (assuming green patchbot).
comment:5 Changed 2 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Let it be so.
comment:6 Changed 2 years ago by
- Milestone changed from sage-8.7 to sage-8.8
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)
comment:7 Changed 2 years ago by
- Branch changed from u/jhpalmieri/ppl-py3 to 8d58a9add1be497fc44401b19472cdc4a967647a
- Resolution set to fixed
- Status changed from positive_review to closed
Not a very pretty fix, but I think it works.
New commits:
trac 24765: py3 fixes for libs/ppl.pyx