Opened 3 years ago

Closed 3 years ago

#27455 closed enhancement (fixed)

remove the deprecated file dict_addition

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.8
Component: refactoring Keywords:
Cc: tscrim, nthiery Merged in:
Authors: Frédéric Chapoton Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: 3f2de29 (Commits, GitHub, GitLab) Commit: 3f2de2960e9ee44684569bfc6aceb41b66d3f4a7
Dependencies: Stopgaps:

Status badges


after #20680

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27455
  • Commit set to 3f2de2960e9ee44684569bfc6aceb41b66d3f4a7
  • Status changed from new to needs_review

New commits:

3f2de29removed the deprecated file dict_addition.pyx

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim nthiery added

green bot, please review

comment:3 Changed 3 years ago by nthiery

  • Status changed from needs_review to positive_review

It was indeed time to get rid of this dead code. Thanks Frédéric!

comment:4 Changed 3 years ago by chapoton

  • Reviewers set to Nicolas M. Thiéry

reviewer name, added.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27455 to 3f2de2960e9ee44684569bfc6aceb41b66d3f4a7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.