Opened 9 months ago

Closed 9 months ago

#27441 closed enhancement (fixed)

Add more trig functions to complex_arb and real_arb

Reported by: slelievre Owned by:
Priority: major Milestone: sage-8.7
Component: numerical Keywords: arb, trig
Cc: fredrik.johansson, mmezzarobba, slelievre Merged in:
Authors: Samuel Lelièvre Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: 4a5f352 (Commits) Commit: 4a5f352caf61c9a74092a3b6635675d789bc050f
Dependencies: Stopgaps:

Description

This ticket wraps more trig functions from arb in complex_arb and real_arb. In particular, sec, csc, sinh, cosh, tanh, coth, sech, csch.

Change History (7)

comment:1 Changed 9 months ago by slelievre

  • Branch set to u/slelievre/acb_sech

comment:2 Changed 9 months ago by slelievre

  • Cc fredrik.johansson mmezzarobba slelievre added
  • Commit set to 4a5f352caf61c9a74092a3b6635675d789bc050f

New commits:

4a5f35227441: Add more trig functions to complex_arb and real_arb

comment:3 Changed 9 months ago by slelievre

  • Status changed from new to needs_review

Attempting to wrap more functions from arb, but not an expert. Would appreciate a careful review.

comment:4 Changed 9 months ago by mmezzarobba

  • Status changed from needs_review to positive_review

Hi Samuel,

LGTM, thanks. A possible improvement (but not a necessary one to merge the ticket IMO) would be to add a couple of special values (e.g., poles) of each function to the examples.

comment:5 Changed 9 months ago by chapoton

reviewer name please

comment:6 Changed 9 months ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba

oops

comment:7 Changed 9 months ago by vbraun

  • Branch changed from u/slelievre/acb_sech to 4a5f352caf61c9a74092a3b6635675d789bc050f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.