Opened 4 years ago
Closed 4 years ago
#27441 closed enhancement (fixed)
Add more trig functions to complex_arb and real_arb
Reported by: | Samuel Lelièvre | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.7 |
Component: | numerical | Keywords: | arb, trig |
Cc: | Fredrik Johansson, Marc Mezzarobba, Samuel Lelièvre | Merged in: | |
Authors: | Samuel Lelièvre | Reviewers: | Marc Mezzarobba |
Report Upstream: | N/A | Work issues: | |
Branch: | 4a5f352 (Commits, GitHub, GitLab) | Commit: | 4a5f352caf61c9a74092a3b6635675d789bc050f |
Dependencies: | Stopgaps: |
Description
This ticket wraps more trig functions from arb in complex_arb
and real_arb
.
In particular, sec
, csc
, sinh
, cosh
, tanh
, coth
, sech
, csch
.
Change History (7)
comment:1 Changed 4 years ago by
Branch: | → u/slelievre/acb_sech |
---|
comment:2 Changed 4 years ago by
Cc: | Fredrik Johansson Marc Mezzarobba Samuel Lelièvre added |
---|---|
Commit: | → 4a5f352caf61c9a74092a3b6635675d789bc050f |
comment:3 Changed 4 years ago by
Status: | new → needs_review |
---|
Attempting to wrap more functions from arb, but not an expert. Would appreciate a careful review.
comment:4 Changed 4 years ago by
Status: | needs_review → positive_review |
---|
Hi Samuel,
LGTM, thanks. A possible improvement (but not a necessary one to merge the ticket IMO) would be to add a couple of special values (e.g., poles) of each function to the examples.
comment:7 Changed 4 years ago by
Branch: | u/slelievre/acb_sech → 4a5f352caf61c9a74092a3b6635675d789bc050f |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
27441: Add more trig functions to complex_arb and real_arb