Opened 3 years ago

Closed 3 years ago

#27433 closed enhancement (fixed)

py3: fix last doctest in mutable_poset

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e7568f1 (Commits, GitHub, GitLab) Commit: e7568f1f109145269653a8aa6dd015c4d0b9d9da
Dependencies: Stopgaps:

Status badges


Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27433
  • Commit set to 9dc622d3c0e71df03818283b7cd68a9ab3999c24
  • Status changed from new to needs_review

New commits:

9dc622dpy3: fix last doctest in mutable_poset

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

I think the alignment that was in the original doctest was helpful (sorry to nitpick about something trivial). Once changed or if you don't care enough to add it back in, you can set a positive review.

comment:4 Changed 3 years ago by git

  • Commit changed from 9dc622d3c0e71df03818283b7cd68a9ab3999c24 to e7568f1f109145269653a8aa6dd015c4d0b9d9da

Branch pushed to git repo; I updated commit sha1. New commits:

e7568f1trac 27433 reviewer request : align

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

done, thx

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27433 to e7568f1f109145269653a8aa6dd015c4d0b9d9da
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.