Opened 3 years ago

Closed 3 years ago

#27429 closed enhancement (fixed)

some little code cleanup

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.7
Component: geometry Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 86fabb7 (Commits, GitHub, GitLab) Commit: 86fabb707cc869c49f8e523f736b1e57ea33c210
Dependencies: Stopgaps:

Status badges

Description

in two files, one about polyhedron, the other about toric varieties

various changes, for cleanness, speed or pep8

Change History (3)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27429
  • Commit set to 86fabb707cc869c49f8e523f736b1e57ea33c210
  • Status changed from new to needs_review

New commits:

86fabb7some little code cleanup of two unrelated files

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27429 to 86fabb707cc869c49f8e523f736b1e57ea33c210
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.