Opened 3 years ago
Closed 3 years ago
#27420 closed enhancement (fixed)
cypari2 version 2.1.0
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  packages: standard  Keywords:  upgrade 
Cc:  fbissey  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  e351bf2 (Commits, GitHub, GitLab)  Commit:  e351bf2f2914e683d5e2028597c45ae8d1b7f855 
Dependencies:  Stopgaps: 
Change History (12)
comment:1 Changed 3 years ago by
 Description modified (diff)
comment:2 Changed 3 years ago by
 Branch set to u/jdemeyer/cypari2_version_2_1_0
comment:3 Changed 3 years ago by
 Commit set to e8747066d1154a01205200a0f724f593cce0b7a1
 Status changed from new to needs_review
comment:4 Changed 3 years ago by
 Commit changed from e8747066d1154a01205200a0f724f593cce0b7a1 to e351bf2f2914e683d5e2028597c45ae8d1b7f855
Branch pushed to git repo; I updated commit sha1. New commits:
e351bf2  Fix omega() method call

comment:5 Changed 3 years ago by
 Cc fbissey added
comment:6 followup: ↓ 7 Changed 3 years ago by
What the changes in sage/schemes/elliptic_curves/period_lattice.py
have to do with the cypari upgrade? If this is fixing a bug, it would better be documented.
comment:7 in reply to: ↑ 6 Changed 3 years ago by
Replying to vdelecroix:
What the changes in
sage/schemes/elliptic_curves/period_lattice.py
have to do with the cypari upgrade?
The handing of precision in omega()
changed: now the precision is taken from the ellinit()
call instead of being passed by the omega()
method. This was needed to fix https://github.com/sagemath/cypari2/issues/73
comment:8 Changed 3 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, looks good to me
comment:9 Changed 3 years ago by
 Status changed from positive_review to needs_info
Hmm, running make ptestlong
, I get possibly unrelated doctests failures in
sage t long src/sage/doctest/test.py sage t long src/sage/combinat/cluster_algebra_quiver/
Could someone else please doublecheck ?
comment:10 Changed 3 years ago by
Could you post the actual failures please instead of only the files with failures?
comment:11 Changed 3 years ago by
 Status changed from needs_info to positive_review
There is a lot of them, and they seem not to be related. I get the same with the previous cypari2. So let me put back to positive review.
Could you please have a look at #27391, Jeroen ?
comment:12 Changed 3 years ago by
 Branch changed from u/jdemeyer/cypari2_version_2_1_0 to e351bf2f2914e683d5e2028597c45ae8d1b7f855
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
cypari2 version 2.1.0