Opened 2 years ago
Closed 2 years ago
#27411 closed enhancement (fixed)
add monoid of knots
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  geometry  Keywords:  knots 
Cc:  mmarco, slelievre  Merged in:  
Authors:  Frédéric Chapoton, Travis Scrimshaw  Reviewers:  Travis Scrimshaw, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  93e4689 (Commits, GitHub, GitLab)  Commit:  93e4689a4b92fa3c3571cf03745266fb37d56f8b 
Dependencies:  Stopgaps: 
Description
Change History (8)
comment:1 Changed 2 years ago by
 Branch set to u/chapoton/27411
 Commit set to 5e594e0554e22856c3d2caac0bc34ea4aca8a1c3
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
Any idea why the elements are failing the category test? Also, why is Element
after Link
in the MRO? (Side note: Link
probably should inherit from SageObject
instead of object
, but that is a separate ticket.)
comment:3 Changed 2 years ago by
No idea. I just did that quickly, and did not try to find what was wrong.
comment:4 Changed 2 years ago by
 Cc mmarco slelievre added
 Keywords knots added
comment:5 Changed 2 years ago by
 Branch changed from u/chapoton/27411 to public/knot_theory/monoid_knots27411
 Commit changed from 5e594e0554e22856c3d2caac0bc34ea4aca8a1c3 to 93e4689a4b92fa3c3571cf03745266fb37d56f8b
 Reviewers set to Travis Scrimshaw, Frédéric Chapoton
Here is the fix for the _test_category
failures. Basically the class being created was Knot
, but the test is checking to make sure it was a subclass of Knots().element_class
. I also fixed the SageObject
whileIwasatit.
New commits:
93e4689  Fixing the _test_category failure and some other details.

comment:6 Changed 2 years ago by
Perfect. Thank you very much for the helpful hand.
I give a positive review to your commit. Are my commits also ok ?
comment:7 Changed 2 years ago by
 Status changed from needs_review to positive_review
Yes. Thank you.
comment:8 Changed 2 years ago by
 Branch changed from public/knot_theory/monoid_knots27411 to 93e4689a4b92fa3c3571cf03745266fb37d56f8b
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
implement the monoid of Knots
the monoid of knots