Opened 8 months ago

Closed 8 months ago

#27410 closed enhancement (fixed)

simplify and speedup of YoungsLatticePrincipalOrderIdeal

Reported by: mantepse Owned by:
Priority: major Milestone: sage-8.7
Component: combinatorics Keywords:
Cc: jmantysalo Merged in:
Authors: Martin Rubey Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 99e5566 (Commits) Commit: 99e556648c67fbc1240e3f464b6ffe3c78d5c1e0
Dependencies: Stopgaps:

Description (last modified by mantepse)

Before:

sage: %timeit [posets.YoungsLatticePrincipalOrderIdeal(la) for la in Partitions(10)]
1 loop, best of 3: 10.5 s per loop

after:

1 loop, best of 3: 1.28 s per loop

Change History (4)

comment:1 Changed 8 months ago by mantepse

  • Branch set to u/mantepse/simplify_and_speedup_of_youngslatticeprincipalorderideal

comment:2 Changed 8 months ago by mantepse

  • Authors set to Martin Rubey
  • Cc jmantysalo added
  • Commit set to 99e556648c67fbc1240e3f464b6ffe3c78d5c1e0
  • Component changed from PLEASE CHANGE to combinatorics
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

99e5566use method from Partition, simplify logic

comment:3 Changed 8 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 8 months ago by vbraun

  • Branch changed from u/mantepse/simplify_and_speedup_of_youngslatticeprincipalorderideal to 99e556648c67fbc1240e3f464b6ffe3c78d5c1e0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.