Opened 3 months ago

Closed 3 months ago

#27407 closed enhancement (fixed)

remove deprecated stuff in designs

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: combinatorial designs Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 12e7489 (Commits) Commit: 12e7489d3dc8581d499069de2f56baea50ea59cc
Dependencies: Stopgaps:

Description

after #17034

Change History (15)

comment:1 Changed 3 months ago by chapoton

  • Branch set to u/chapoton/27407
  • Commit set to 424a0f66aec9427d4bf17615e9a064b2004807ed
  • Status changed from new to needs_review

New commits:

424a0f6remove deprecated stuff in designs (after trac 17034)

comment:2 Changed 3 months ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to needs_info

Why don't you remove the argument existence?

comment:3 Changed 3 months ago by git

  • Commit changed from 424a0f66aec9427d4bf17615e9a064b2004807ed to 1d61a215a59841f95ce0cd06d4a814a67ce1560a

Branch pushed to git repo; I updated commit sha1. New commits:

1d61a21trac 27407 remove argument existence

comment:4 Changed 3 months ago by chapoton

J'ai oublié, merci.

comment:5 Changed 3 months ago by git

  • Commit changed from 1d61a215a59841f95ce0cd06d4a814a67ce1560a to bccb48acc150ef4b285bac313b37ae2c3e6c67c9

Branch pushed to git repo; I updated commit sha1. New commits:

bccb48aforgot to remove one existence

comment:6 Changed 3 months ago by chapoton

  • Status changed from needs_info to needs_review

comment:7 Changed 3 months ago by vdelecroix

  • Status changed from needs_review to needs_work

k is supposed to be a non-negative integer. Any non integral type (such as None) should raise a TypeError and a negative value should raise a ValueError.

comment:8 Changed 3 months ago by git

  • Commit changed from bccb48acc150ef4b285bac313b37ae2c3e6c67c9 to 4edfcd7967c1b7657a46444b02016ed8b1f3ed8d

Branch pushed to git repo; I updated commit sha1. New commits:

4edfcd7trac 27407 some details about k

comment:9 Changed 3 months ago by chapoton

bon, bon. Voilà

comment:10 Changed 3 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:11 Changed 3 months ago by vdelecroix

Désolé: le message d'erreur please use "largest_available_k" est vraiment malvenu. Par exemple k must be a positive integer.

comment:12 Changed 3 months ago by git

  • Commit changed from 4edfcd7967c1b7657a46444b02016ed8b1f3ed8d to 12e7489d3dc8581d499069de2f56baea50ea59cc

Branch pushed to git repo; I updated commit sha1. New commits:

12e7489trac 27407 change the message

comment:13 Changed 3 months ago by chapoton

mieux comme ca ?

comment:14 Changed 3 months ago by vdelecroix

  • Status changed from needs_review to positive_review

Magnifique :-)

comment:15 Changed 3 months ago by vbraun

  • Branch changed from u/chapoton/27407 to 12e7489d3dc8581d499069de2f56baea50ea59cc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.