Opened 3 years ago

Closed 3 years ago

#27406 closed enhancement (fixed)

py3: various fixes about print and hash

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 82de003 (Commits, GitHub, GitLab) Commit: 82de003ad9f99f1174625abf81221310807ac0d2
Dependencies: Stopgaps:

Status badges

Description

Some hash-related doctest failures have been kept for another ticket.

Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27406
  • Commit set to 66e480f33130d919d1b8375b6fc851ea95c93232
  • Status changed from new to needs_review

New commits:

66e480fpy3: various fixes about print and hash

comment:2 Changed 3 years ago by dcoudert

in src/sage/sets/set.py, you wrote hash(s) instead of hash(t)

-            sage: t = tuple(s)
-            sage: hash(s) != hash(tuple(X.set()))
+            sage: t = tuple(s)
+            sage: hash(t) != hash(tuple(X.set()))

comment:3 Changed 3 years ago by git

  • Commit changed from 66e480f33130d919d1b8375b6fc851ea95c93232 to 4c00499a069ea45e716992f85b88198f38c64fea

Branch pushed to git repo; I updated commit sha1. New commits:

4c00499fix one detail in hash doctest

comment:4 Changed 3 years ago by chapoton

no, no, we really want to check that s can be hashed.

I have removed the superfluous line t=tuple(s)

comment:5 Changed 3 years ago by git

  • Commit changed from 4c00499a069ea45e716992f85b88198f38c64fea to 82de003ad9f99f1174625abf81221310807ac0d2

Branch pushed to git repo; I updated commit sha1. New commits:

82de003trac 27406 fix sorting of one doctest in crystals

comment:6 Changed 3 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

OK.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27406 to 82de003ad9f99f1174625abf81221310807ac0d2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.