Opened 11 months ago
Closed 11 months ago
#27392 closed enhancement (fixed)
the omegasignature of knots and links
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  geometry  Keywords:  knots 
Cc:  mmarco, slelievre, tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  4ed1cc8 (Commits)  Commit:  4ed1cc8c9522b0730490d500de31951fe84f5699 
Dependencies:  Stopgaps: 
Description
as a small variant of the signature, the omegasignature is a function of omega in S1, piecewise constant on S1
Change History (8)
comment:1 Changed 11 months ago by
 Branch set to u/chapoton/27392
 Commit set to cd94b92f47648b69508d03adcab289bef8192855
 Status changed from new to needs_review
comment:2 Changed 11 months ago by
 Cc mmarco slelievre tscrim added
 Keywords knots added
green bot, please review
comment:3 Changed 11 months ago by
 Reviewers set to Travis Scrimshaw
The definition is a little awkward in English to me. I would write
This is defined as the signature of the symmetric matrix .. MATH:: V + V^{t}, where `V` is the :meth:`Seifert matrix <seifert_matrix>`.
Another option would be a separate initial sentence Let `V` be the :meth:`Seifert matrix <seifert_matrix>`.
Otherwise LGTM.
comment:4 Changed 11 months ago by
 Commit changed from cd94b92f47648b69508d03adcab289bef8192855 to 4ed1cc8c9522b0730490d500de31951fe84f5699
Branch pushed to git repo; I updated commit sha1. New commits:
4ed1cc8  trac 27392 better English for the doc, plus other details

comment:5 Changed 11 months ago by
Done.
Many thanks for still taking the time to review my many tickets, and sorry for the rough English.
comment:6 Changed 11 months ago by
Thank you. No problem. A lot of these tickets are fairly easy to review (with the patchbot). For those sentences, I was thinking it might have been a natural construct in French :)
.
comment:7 Changed 11 months ago by
 Status changed from needs_review to positive_review
comment:8 Changed 11 months ago by
 Branch changed from u/chapoton/27392 to 4ed1cc8c9522b0730490d500de31951fe84f5699
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
provide the omegasignature of knots and links