#27388 closed defect (fixed)

spkg installation: convert read-only files to owner-writable

Reported by: jhpalmieri Owned by:
Priority: critical Milestone: sage-8.7
Component: build Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: eec04c7 (Commits) Commit: eec04c7ace6b62913bb78fdcaa6205590f2ca0ec
Dependencies: Stopgaps:

Description

In recent versions of the gap package, the file local/share/gap/pkg/ctbllib/tst/docxpl.tst gets installed with permissions -r--r--r--, because these are its permissions in the tarball. This can cause problems when upgrading if that involves overwriting that file. So let's fix permissions in the installation process.

Change History (4)

comment:1 Changed 11 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/gap-chmod

comment:2 Changed 11 months ago by jhpalmieri

  • Commit set to eec04c7ace6b62913bb78fdcaa6205590f2ca0ec
  • Status changed from new to needs_review

New commits:

eec04c7trac 27388: In Sage's tar_file.py, set "w" permission for owner

comment:3 Changed 11 months ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

I agree--there's really no reason to be installing read-only files. The one case that we know of, of one file, in the GAP tarball actually comes from a mis-distributed GAP package. But the GAP developers refuse to fix it unless the developer of that package fixes it, and they in turn are unresponsive.

This should be fixed at the source, but regardless it's useful to go ahead and apply sensible permissions to files when we unpack tarballs.

comment:4 Changed 11 months ago by vbraun

  • Branch changed from u/jhpalmieri/gap-chmod to eec04c7ace6b62913bb78fdcaa6205590f2ca0ec
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.