Opened 4 years ago

Last modified 4 years ago

#27384 closed defect

Apply Cysignals fix for Cygwin exception handler on sigaltstack — at Version 1

Reported by: Erik Bray Owned by:
Priority: blocker Milestone: sage-duplicate/invalid/wontfix
Component: porting: Cygwin Keywords:
Cc: Jeroen Demeyer Merged in:
Authors: Erik Bray Reviewers:
Report Upstream: N/A Work issues:
Branch: u/embray/cygwin/patch-cysignals-altstack-exception-handler (Commits, GitHub, GitLab) Commit: f95dcff22000f525b3a114d89dd10b2e134589fa
Dependencies: Stopgaps:

Status badges

Description (last modified by Erik Bray)

This adds a version of the patch from https://github.com/sagemath/cysignals/pull/108 modified to apply to cysignals 1.8.1.

Since the issue only affects Cygwin I thought for now it would be easier (as in #27267) to apply the patch locally, rather than wait on Jeroen to approve the upstream PR, make a new release of cysignals, and make Sage depend on that release.

This fix certainly resolves the blocker issue well-enough for me for the time being. Fixing this is a prerequisite for fixing #27214.

Change History (1)

comment:1 Changed 4 years ago by Erik Bray

Authors: Erik Bray
Branch: u/embray/cygwin/patch-cysignals-altstack-exception-handler
Cc: Jeroen Demeyer added
Commit: f95dcff22000f525b3a114d89dd10b2e134589fa
Description: modified (diff)
Status: newneeds_review

New commits:

f95dcffTrac #27384: Patch cysignals with fix for Cygwin's sigaltstack exception
Note: See TracTickets for help on using tickets.