Opened 9 months ago

Closed 9 months ago

#27378 closed enhancement (fixed)

Py3: Fix graphic_matroids.py for python3

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6e12295 (Commits) Commit: 6e12295c7bba430d2ba7defa08cae3f1167c0a6f
Dependencies: Stopgaps:

Description (last modified by vklein)

Fix graphic_matroids.py for python3. For graphs use edge_iterator() and vertex_iterator() instead of edges() and vertices() to avoid comparison operator bug when sort is called. The remaining failling doctests should be fixed outside of this file (graphs/connectivity.pyx and matroid.pyx

Change History (9)

comment:1 Changed 9 months ago by vklein

  • Authors set to Vincent Klein
  • Component changed from PLEASE CHANGE to python3
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 9 months ago by vklein

  • Branch set to u/vklein/27378

comment:3 Changed 9 months ago by vklein

  • Commit set to 6e12295c7bba430d2ba7defa08cae3f1167c0a6f
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

6e12295Trac #27378: Fix graphix_matroid.py for python3

comment:4 Changed 9 months ago by vklein

  • Status changed from needs_review to needs_work
  • Summary changed from Py3: Fix graphic_matroids.py for python3 to Py3: Several fixes in matroid module for python3

Modify the scope of the ticket to fix more doctests failures in the matroid module.

comment:5 Changed 9 months ago by vklein

  • Status changed from needs_work to needs_review
  • Summary changed from Py3: Several fixes in matroid module for python3 to Py3: Fix graphic_matroids.py for python3

change of opinion

comment:6 Changed 9 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good. Merci pour tout le travail accompli pour python3 !

comment:7 Changed 9 months ago by vklein

Merci à toi !

comment:8 Changed 9 months ago by vklein

  • Description modified (diff)

comment:9 Changed 9 months ago by vbraun

  • Branch changed from u/vklein/27378 to 6e12295c7bba430d2ba7defa08cae3f1167c0a6f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.