Opened 3 years ago

Closed 3 years ago

#27342 closed enhancement (fixed)

py3: some tiny fixes in numerical folder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ba61c9e (Commits, GitHub, GitLab) Commit: ba61c9e22305cdee79e50a09075c4fb1af9db3d6
Dependencies: Stopgaps:

Status badges


Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27342
  • Commit set to ba61c9e22305cdee79e50a09075c4fb1af9db3d6
  • Status changed from new to needs_review

New commits:

ba61c9epy3: some tiny fixes in numerical folder

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

I don't have the Python3 version to test, but I do not think this change is necessary from looking at the code:

-            sage: p.add_col(range(5), range(5))
+            sage: p.add_col(list(range(5)), list(range(5)))

Even if it does fail, I think it would be better to have the original input work. Otherwise LGTM.

comment:3 Changed 3 years ago by chapoton

Thanks for the review. The type "list" is hardcoded (in the cdef line) for both entries of this function. This could be enhanced, but not now.

comment:4 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

Ah, I see. I missed that. Sorry for the noise.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27342 to ba61c9e22305cdee79e50a09075c4fb1af9db3d6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.