Opened 3 years ago

Closed 3 years ago

#27329 closed defect (fixed)

Polyhedron/base: very minor "fixes"

Reported by: dkrenn Owned by:
Priority: trivial Milestone: sage-8.7
Component: geometry Keywords: easy review, beginner
Cc: Merged in:
Authors: Daniel Krenn Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 74470e2 (Commits, GitHub, GitLab) Commit: 74470e28c89691c95ed7d9f862e44b1bdc15a9f5
Dependencies: Stopgaps:

Status badges

Description

This ticket contains some collected very minor "fixes" (not even sure if they would be called that way) after going through the docs/file.

Change History (4)

comment:1 Changed 3 years ago by dkrenn

  • Branch set to u/dkrenn/minor-polyhedra

comment:2 Changed 3 years ago by dkrenn

  • Commit set to 74470e28c89691c95ed7d9f862e44b1bdc15a9f5
  • Keywords easy review beginner added
  • Priority changed from major to trivial
  • Status changed from new to needs_review

New commits:

1ca3e2cTrac #27329: actually use **kwds as promised in docs
4efdb48Trac #27329: insert 3 whitespaces (PEP8)
74470e2Trac #27329: insert an additional doctest enhancing the readability of

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/dkrenn/minor-polyhedra to 74470e28c89691c95ed7d9f862e44b1bdc15a9f5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.